| kona | Trojita has a few issues for me on pinephone, notably adding an account won't accept input | 00:03 |
|---|---|---|
| kona | Will look at it | 00:03 |
| Wizzup | kona: hmm | 00:58 |
| Wizzup | kona: focussing on modest is good | 00:58 |
| Wizzup | I am not sure if trojita is fully hildonized | 00:58 |
| kona | Wizzup I will start with modest and see what's what | 01:21 |
| Wizzup | kona: cool, lmk if you have questions / need help | 01:37 |
| kona | Libcal builds, so my build vm probably works :) | 08:06 |
| Wizzup | kona: yes | 09:44 |
| freemangordon | kona: why do you build libcal, -dev it should be in the repos? | 09:56 |
| freemangordon | also, modest will need osso-abook (WIP) and HTML renderer replacement | 09:57 |
| freemangordon | I am working at osso-abook as we speak, so can prioritize whatever modest needs. It may already be there though | 09:58 |
| Wizzup | freemangordon: he's working on modest, so I think libcal is just a way to test the build vm | 09:59 |
| freemangordon | thought so, just wanted to be sure | 09:59 |
| kona | freemangordon: yes, just testing | 18:10 |
| freemangordon | kona: ok. Did you see my note re osso-abook? | 19:46 |
| kona | Yes, will try to figure out what I need, sorting out a missing build dep on my vm presently | 19:46 |
| freemangordon | hmm, thre shouldn;t be any but a dependency to microb-dev (or something like that) | 19:47 |
| freemangordon | but, you'll need to build tinymail IIRC | 19:47 |
| kona | It might be because I cloned only modest instead of the whole leste repo? | 19:48 |
| uvos | freemangordon: so i have been looking at abook /lib | 19:48 |
| freemangordon | you don;t need the whole leste repo :) | 19:48 |
| kona | Some gtk doc dependency breaking autoconf | 19:49 |
| freemangordon | kona: however, I am not sure timymail is int ther repo | 19:49 |
| freemangordon | *tinymail | 19:49 |
| freemangordon | uvos: and? | 19:49 |
| uvos | freemangordon: im not sure i understand it quite yet, but is it correct so say that other apps shal use this to for instance show the avatar by creating a gtk widget of the type OssoABookAvatar? | 19:50 |
| uvos | and so on | 19:50 |
| uvos | for abook functionality | 19:50 |
| freemangordon | uvos: not really, all this is alreay there | 19:50 |
| uvos | ok but if i want to use abook | 19:50 |
| uvos | in some other app | 19:50 |
| freemangordon | you need only OssoAbookAccountSelector | 19:50 |
| uvos | how would i aquire the information | 19:50 |
| uvos | but i need the avatar | 19:50 |
| freemangordon | it is there | 19:50 |
| freemangordon | just a second | 19:50 |
| freemangordon | uvos: you need an avatar of a particular account, no? | 19:51 |
| freemangordon | so, how do you know which account you need avatar of? | 19:51 |
| freemangordon | you need that for sphone, correct? | 19:52 |
| uvos | freemangordon: yes im trying to figure out how "bad" it would be to have optional abook support in sphone | 19:52 |
| uvos | yeah so i have some number, i can look up what account i need via evolution (or abook but havent foudnd if it can yet) | 19:52 |
| freemangordon | sec | 19:52 |
| uvos | and then i need presence and the avatar and sutch | 19:52 |
| freemangordon | no, you don;t need evolution | 19:52 |
| freemangordon | all you need is abook, the functinality is already there | 19:53 |
| freemangordon | p, li { white-space: pre-wrap; } osso_abook_contact_get_photo | 19:53 |
| freemangordon | osso_abook_contact_get_photo() | 19:53 |
| uvos | hmm ok | 19:54 |
| uvos | and looking up a account from the number | 19:54 |
| freemangordon | actually it is ' | 19:55 |
| kona | Freemangordon: tiny mail in 0mark repo | 19:55 |
| freemangordon | contact' not 'account' | 19:55 |
| uvos | sure | 19:55 |
| uvos | OssoABookContact | 19:55 |
| freemangordon | uvos: gimme a second to fint the functions you need to call | 19:55 |
| freemangordon | *find | 19:55 |
| freemangordon | kona: sorry, can;t parse, please rephrase | 19:55 |
| freemangordon | uvos: I think it is osso_abook_aggregator_find_contacts_for_phone_number() | 19:56 |
| freemangordon | maybe I shall feed ida with callui and see what functions it uses | 19:57 |
| uvos | ah ok that looks like it would work | 19:57 |
| uvos | ok so there is something i really dont like about abook. it, correct me if im wrong, but its apears to be mixing frontend and backend. There seams no reason to have the thing that provides presence and | 19:57 |
| kona | Freemangordon: I'm planning to work with tinymail from repo:https://github.com/0mark/tinymail | 19:57 |
| uvos | account info and sutch depend and link to a gui toolkit | 19:57 |
| freemangordon | kona: why not use tinymail from CSSU? | 19:58 |
| kona | Cssu? | 19:58 |
| freemangordon | uvos: actually, it is the GUI toolkit | 19:58 |
| uvos | freemangordon: sure but there should be something below it | 19:58 |
| freemangordon | not a backend | 19:58 |
| uvos | that provides the account info presence and sutch | 19:58 |
| freemangordon | yes, telepathy and EDS | 19:58 |
| uvos | okay | 19:58 |
| freemangordon | telepathy provides presence | 19:58 |
| uvos | hmm | 19:59 |
| freemangordon | EDS - addressbooks | 19:59 |
| uvos | so maybe it would make more sense for me to avoid using abook and just geting the info from there... | 19:59 |
| freemangordon | if you look at OssoAbookContact it is based on EContact | 19:59 |
| uvos | since then i can also port sphone to gtk3 | 19:59 |
| freemangordon | uvos: and you have to write all from scratch | 19:59 |
| uvos | also how are qt apps supposed to work | 19:59 |
| freemangordon | up to you ofc | 19:59 |
| freemangordon | how's that related/ | 20:00 |
| uvos | like trojita | 20:00 |
| freemangordon | ? | 20:00 |
| uvos | i also maintain that | 20:00 |
| uvos | well a qt app on maemo will have the same problem | 20:00 |
| freemangordon | don;t know, we have to look in some fremantle example | 20:00 |
| freemangordon | kona: sec | 20:00 |
| freemangordon | uvos: :nod: | 20:00 |
| freemangordon | it is a general issue | 20:00 |
| kona | K | 20:00 |
| uvos | maybe we should create (or exists) some thin wrapper | 20:00 |
| uvos | libmaemocontacts | 20:00 |
| uvos | or whatever that gives pixmaps and info in one place | 20:01 |
| freemangordon | kona: https://github.com/community-ssu/tinymail | 20:01 |
| kona | Ty! | 20:01 |
| freemangordon | uvos: that does what? | 20:01 |
| uvos | just aggregates what abook gets from tp and from eds | 20:01 |
| freemangordon | but it is already aggregated | 20:01 |
| uvos | in abook | 20:02 |
| freemangordon | ah, you mean to rewrite abook? | 20:02 |
| uvos | no | 20:02 |
| uvos | not the gui part | 20:02 |
| uvos | just aggreate in a gui toolkit netural way | 20:02 |
| freemangordon | OssoAbookContact doesn't have GUI parts | 20:02 |
| uvos | yeah but it deppends on gtk2 | 20:02 |
| freemangordon | so maybe we can split GUI from TP/EDS | 20:02 |
| uvos | yeah | 20:03 |
| uvos | thats what i was thinking | 20:03 |
| uvos | then we can make the backend lib something you can use elsewhere too | 20:03 |
| freemangordon | but, I am not going into this before abook is complete | 20:04 |
| uvos | since ofc hildoized gtk2 will be maemo specific forever | 20:04 |
| freemangordon | otherwise that's a wise move | 20:04 |
| uvos | sure | 20:04 |
| freemangordon | yeah, should be possible to split | 20:04 |
| uvos | great | 20:04 |
| uvos | ok finishing re first makes sense | 20:05 |
| freemangordon | but, you;ll be missing stuff like contact selector | 20:05 |
| uvos | ok | 20:05 |
| freemangordon | which does lot more that may look initially | 20:05 |
| freemangordon | because you have voicemail cointacts, for example | 20:05 |
| uvos | maybe we can spinn it into a seperate process for qt / gtk3 whatever apps | 20:06 |
| freemangordon | or 'me' contact | 20:06 |
| uvos | (thinking qt maemo apps here) | 20:06 |
| freemangordon | yes, I think this is wiser | 20:06 |
| uvos | ok | 20:06 |
| freemangordon | but maybe this is already implememted bu the addressbook application | 20:06 |
| freemangordon | *implemented by | 20:06 |
| freemangordon | which is in early REing stages | 20:07 |
| uvos | okay | 20:07 |
| uvos | carry on then | 20:07 |
| freemangordon | after the lib :( | 20:07 |
| freemangordon | uvos: I think maybe a better approach is to start with abook and implement something different after you are aware of all the requirements | 20:08 |
| freemangordon | what about the call history? | 20:08 |
| freemangordon | already said about the contact selector | 20:09 |
| freemangordon | it is not really trivial to implement one | 20:09 |
| uvos | sphone dose its own call history in sql rn, not sure how to integrate it | 20:09 |
| uvos | maybe we can have it infrom tp somehow | 20:09 |
| freemangordon | well, you can;t keep call history out of contact history | 20:10 |
| freemangordon | and contact history is in RtCom | 20:10 |
| freemangordon | by contact history I mean - calls, chats, SMSes, etc | 20:10 |
| uvos | ofono allso keeps its own history | 20:10 |
| freemangordon | it will become inconsistent otherwise | 20:10 |
| uvos | atm | 20:10 |
| uvos | so theres mutliple layers here allready doing the same stuff | 20:11 |
| freemangordon | sure, but this is not what you expect from a phone | 20:11 |
| uvos | not sure how to do it best | 20:11 |
| uvos | sure | 20:11 |
| freemangordon | uvos: I would say that's why Nokia integrated everything in one place | 20:11 |
| uvos | sure so we need something in the telephone stack inform that one place about calls/sms | 20:11 |
| freemangordon | maybe a better approach would be to de-hildonize osso-abook | 20:11 |
| uvos | im thinking about where | 20:12 |
| freemangordon | or rather - to have GUI parts in plain GTK/QT or whatever | 20:12 |
| freemangordon | but this is a huge amount of work | 20:12 |
| freemangordon | also, do you plan sphone to support dial over TP? like doing gtalk voice calls? | 20:14 |
| uvos | yeah i want to make the backend in sphone a plugin | 20:16 |
| uvos | so then you could have tp as one | 20:16 |
| uvos | but thats going to be a rather late addition | 20:16 |
| uvos | since it needs some kind of contacts and fully working calls (audio routing) first | 20:17 |
| freemangordon | ok, but what are you going to provide to the backend? EContact? | 20:17 |
| uvos | a string with what to dial | 20:18 |
| uvos | or what do you mean? | 20:18 |
| freemangordon | yes, that | 20:18 |
| freemangordon | but, how a string is going to describe a contact? | 20:18 |
| freemangordon | some internal format? | 20:18 |
| uvos | havent thought quite that far yet so at first ill just make a plugin of the ofono backend | 20:19 |
| freemangordon | just an idea - either use EContact or plain vcf | 20:19 |
| uvos | that just gets a string with the number rn | 20:19 |
| uvos | ok yeah something like that makes sense | 20:19 |
| freemangordon | everyone shall be able to understand vcf | 20:19 |
| freemangordon | if you want to avoid EDS dependency | 20:19 |
| freemangordon | vcf carries the avatar as well | 20:20 |
| freemangordon | BTW, that shall work with abook too | 20:20 |
| uvos | ok | 20:21 |
| freemangordon | abook can understand vcf I guess | 20:21 |
| uvos | ok | 20:21 |
| uvos | yeah vcf makes sense | 20:21 |
| uvos | but near term sphone will stay ofono so this is for later | 20:21 |
| freemangordon | I would still prefer full abook integration ofc :P | 20:21 |
| freemangordon | Which I am going to implement soon or later | 20:22 |
| freemangordon | have you ever seen fremantle dialer? | 20:22 |
| uvos | yeah | 20:22 |
| freemangordon | ok | 20:22 |
| Wizzup | freemangordon: tinymail from cssu is too old for using the gtk html thing, it needs to be newer, see the notes from the same person @ | 21:47 |
| Wizzup | https://github.com/0mark/modest4leste | 21:49 |
| Wizzup | freemangordon: did you see https://github.com/maemo-leste/connui-common/pull/1 and https://github.com/maemo-leste/connui-internet/pull/3 | 21:49 |
| freemangordon | oh, https://github.com/0mark/tinymail/commits/master is already based on CSSU | 21:50 |
| freemangordon | ok, my bad for not checking it first | 21:52 |
| freemangordon | Wizzup: just had a look at it, seems fine (functionality wise) but usual notes by my side apply (coding style, #defines :p ) | 21:54 |
| Wizzup | the original code also doesn't do defines for the paths | 21:55 |
| Wizzup | I thought I mostly kept the same code standard there | 21:55 |
| freemangordon | doesn't it? ok, maybe an oversignt by me, but it has to be fixed anyways | 21:56 |
| Wizzup | I am also not sure where we want to define it too | 21:56 |
| freemangordon | I mean "/system/osso/connectivity/srv_provider" | 21:56 |
| freemangordon | not the subdirs/icon names | 21:56 |
| Wizzup | yeah, should that go in icd2-dev or something? | 21:56 |
| freemangordon | I think it is already there, lemme find it | 21:57 |
| uvos | tinymail would likely benefit a lot by porting to gtk3 | 21:57 |
| freemangordon | #define ICD_GCONF_SETTINGS "/system/osso/connectivity" | 21:57 |
| uvos | wrt more up to date bindings to html renderers | 21:57 |
| * Wizzup would rather have minimal html renderers to start with | 21:57 | |
| Wizzup | freemangordon: just for that part? I see | 21:58 |
| uvos | is webkitgtk for gtk2 still updated at all | 21:58 |
| uvos | it appears arch at least dropped it in 2017 | 21:58 |
| Wizzup | debian oldstable should I suppose | 21:58 |
| freemangordon | #define ICD_GCONF_SRV_PROVIDERS ICD_GCONF_SETTINGS "/srv_provider" | 21:58 |
| Wizzup | freemangordon: ok, yeah, that wasn't used in that file | 21:59 |
| kona | Freemangordon, should I join cssu project? | 21:59 |
| uvos | Wizzup: yeah @ minimal html, i think the internal extreamly limited html5 renderer of qt5 seams pretty ideal for a mail client | 21:59 |
| freemangordon | Wizzup: see, basically I try to do my best to make the code 'beautiful' while REing, but sometimes I miss stuff. If you see I didn;t use defines on some places, please fix, it was not intentional | 22:00 |
| freemangordon | kona: no | 22:00 |
| Wizzup | uvos: I'd still like to get modest ported by just upgrading to newer libs if they exist, and then look at potential upgrades, it's quite low resource and nice, even on fremantle still | 22:00 |
| Wizzup | but yeah, qt5 could work | 22:01 |
| Wizzup | kona: maemo-leste basically replaces cssu | 22:01 |
| freemangordon | the repo you linked initially is already already based on cssu | 22:01 |
| kona | Oh, I see. Yeah, will continue w 0mark repo then | 22:01 |
| kona | Ok. | 22:01 |
| uvos | you can allmost run trojita with the hildon qt platform btw | 22:01 |
| freemangordon | already already to be read as already :) | 22:01 |
| uvos | you would just have to hide some menu elements | 22:01 |
| uvos | ill do that eventually | 22:01 |
| uvos | (ofc no trojta is very mucht a stand alone email client) | 22:02 |
| freemangordon | uvos: and it doesn;t integrate with osso-abook :: | 22:02 |
| freemangordon | :) | 22:02 |
| uvos | yes | 22:02 |
| Wizzup | freemangordon: I'll fix it here | 22:02 |
| uvos | adding some abooks support would be conignant on untagling the gtk2 depenacy of that again | 22:02 |
| freemangordon | Wizzup: well, feel free to grep for other places :p, maybe in a separate commit? | 22:03 |
| freemangordon | uvos: sure, but we already have an email client which integrates with abook | 22:03 |
| freemangordon | as you said - diversity :p | 22:03 |
| lel | MerlijnWajer synchronize a pull request: https://github.com/maemo-leste/connui-common/pull/1 (iap-common: add default_custom_ui provider parsing) | 22:03 |
| uvos | right realistcly it would need porting to gtk3 for security wrt its html renderer | 22:04 |
| uvos | so it has the same problem | 22:04 |
| Wizzup | freemangordon: thanks for the review, will fix that up now | 22:08 |
| freemangordon | Wizzup: maybe I shall provide you with uncrustify config | 22:08 |
| lel | MerlijnWajer synchronize a pull request: https://github.com/maemo-leste/connui-common/pull/1 (iap-common: add default_custom_ui provider parsing) | 22:08 |
| freemangordon | it will be easier, gimme a minute | 22:08 |
| freemangordon | Wizzup: https://pastebin.com/jQpXr1sN | 22:14 |
| freemangordon | the only thing I was not able to setup correctly is the line continuation | 22:14 |
| freemangordon | qtcreator uses 2 * indent to align the first continuation line where splitting assignment and function parameters | 22:15 |
| freemangordon | s/where/when | 22:16 |
| freemangordon | Wizzup: oh, what I pasted is cfg file for uncrustify | 22:16 |
| freemangordon | that matches the coding style I use in all projects I started recently | 22:16 |
| freemangordon | well, ~matches (line continuation is not matched) | 22:17 |
| Wizzup | if this config works well, maybe we should have them in a repo somewhere, or on the wiki | 22:17 |
| Wizzup | (+ what to use per repo, I guess) | 22:18 |
| freemangordon | it works, besides the note | 22:18 |
| freemangordon | I was not able to find a way to fix it | 22:18 |
| freemangordon | BTW, how did you manage to do it correctly here https://github.com/maemo-leste/connui-common/pull/1/commits/2b8345dfd1a1359b97cf5857c7859c553eb5db5d#diff-29b482d64fa71326355151232c6b808e8b9009711de15fb6d5773ebd5a4125e4R548? by hand? | 22:19 |
| Wizzup | yes I fixed things by hand some minutes ago | 22:20 |
| freemangordon | ok, this line is an example of some weird, hardcoded QtCreator behaviour, it puts basically 3*indent spaces when continuing on the next line | 22:21 |
| freemangordon | I am not sure how to deal with that re auto indent | 22:22 |
| Wizzup | we could also just accept uncrustify behaviour in it perhaps | 22:22 |
| * Wizzup going to get some sleep soon, intense day | 22:23 | |
| freemangordon | me too | 22:25 |
| freemangordon | yeah, maybe | 22:25 |
| Wizzup | parazyd: btw, maybe if you have some time tomorrow you can think about some debhelper or re-usable postinst scripts to insert libicd_network_tor.so (or others) in the gconf string list for the network types | 22:26 |
| freemangordon | Wizzup: shall I merge the PR? | 22:26 |
| Wizzup | parazyd: and upon removal remove it from the list | 22:26 |
| Wizzup | freemangordon: should be good yeah | 22:26 |
| freemangordon | ping me when you at it (dh_ sthingie) | 22:26 |
| freemangordon | *thingie | 22:27 |
| lel | freemangordon closed a pull request: https://github.com/maemo-leste/connui-common/pull/1 (iap-common: add default_custom_ui provider parsing) | 22:27 |
| uvos | if you can right now the hildon pr would be usefull to also close | 22:43 |
| freemangordon | uvos: will do tomorrow, I promise | 23:10 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!