| Wizzup | uvos: thanks | 00:18 |
|---|---|---|
| freemangordon | uvos: why did you remove https://github.com/maemo-leste/mce/commit/1fa30fa11ec14bd8a422faf53eada9b261f5454d#diff-889c5495b68d2a0c0d1f238818716a71939918499efbc0fc6d2994319624fc67L6? | 07:58 |
| freemangordon | do you already pass -Wl,--as-needed? as I didn;t see it being passed | 07:59 |
| freemangordon | and this makes huge difference in terms of imported libs | 07:59 |
| Wizzup | freemangordon: it is in the CMakeLists.txt | 09:48 |
| Wizzup | freemangordon: see backlog | 09:48 |
| Wizzup | not sure about -Wl,as--needed specifically btw but we did discuss it | 09:48 |
| sicelo | uvos: i also have a minor PR against droid4-battery-calibration. | 11:06 |
| freemangordon | Wizzup: 'git grep as-needed' gives no result | 13:08 |
| freemangordon | what do you mean by "we did discuss it"? Did I miss something in the backlog? | 13:09 |
| Wizzup | freemangordon: yes your commit was discussed | 13:16 |
| Wizzup | is it not in the backlog? | 13:16 |
| freemangordon | Wizzup: it is, but I see nothing about -Wl,as--needed | 15:34 |
| freemangordon | maybe I have missed it, thus my question | 15:34 |
| uvos | freemangordon: hardening=+all => no effect, is added by dh allready | 15:38 |
| uvos | freemangordon: -Wall => is in cmake allready+ lots of other warning flags, having it here again is bad because this will cause confusion if the flags need to be chainged | 15:39 |
| uvos | freemangordon: -Wl,--as-needed => would have been usefull in the previous build system where every module is linked to every dependancy, no we link everything with seperate flags, thus if this dose anything its because a mistake was made in what x module should link to wich should be fixed instead. | 15:40 |
| uvos | s/no/now | 15:40 |
| uvos | and if for some reason -Wl,--as-needed is usefullt (probubly because of a bad pkg-config line) this is the wrong place to put it | 15:42 |
| uvos | mce is not build just for debian | 15:42 |
| uvos | thus overall this commit was just bad => revert | 15:43 |
| uvos | sicelo: i wrote the script but i dont think i own this package | 15:46 |
| uvos | sicelo: so this is something for parazyd | 15:46 |
| uvos | sicelo: but yes your pr is correct and this was a mistake made while renaming the package | 15:48 |
| uvos | sicelo: yeah ineed i dont have commit rights on that one | 15:49 |
| freemangordon | uvos: for sure there are bad .pc files | 16:43 |
| freemangordon | so please consider adding -Wl,--as-needed wherever appropriate for the build system | 16:43 |
| lel | MerlijnWajer created a repository: https://github.com/maemo-leste/telepathy-noise | 21:02 |
| Wizzup | ok, I can see the irc msgs I send to my bot come in conversations live :) | 23:15 |
| Wizzup | sending also works | 23:15 |
| Wizzup | uvos: you just need to set remote_name in the el event to get it to show up in remotes I think | 23:26 |
| Wizzup | https://wizzup.org/telepathy-conversations.png | 23:30 |
| Wizzup | works well for sms too :) | 23:49 |
| Wizzup | (barring the ofono bugs) | 23:49 |
| sicelo | tested with N900? i suppose those ofono bugs aren't there? | 23:50 |
| Wizzup | tested on droid4 | 23:51 |
| Wizzup | and yes they are clearly droid4 bugs | 23:51 |
| Wizzup | (just making modem offline and online again flushes messages out and sends delivery reports) | 23:54 |
| Wizzup | one thing I need to look at is that telepathy-ring doesn't allow a process id to have more than one telepathy-ring client, which is just weird | 23:54 |
| Wizzup | but that's not a super big problem right now | 23:54 |
| Wizzup | (doesn't look like there should be a reason for that) | 23:55 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
