BlagovestPetrov[ | https://github.com/maemo-leste/osso-systemui/pull/2 :)) | 01:00 |
---|---|---|
BlagovestPetrov[ | https://github.com/maemo-leste/osso-systemui-powerkeymenu/pull/2 | 01:14 |
BlagovestPetrov[ | https://github.com/maemo-leste/osso-systemui-tklock/pull/3 | 01:29 |
BlagovestPetrov[ | I'll continue with the rest of systemui packages tomorrow, if you aggree that ignoring the GTK warnings is ok | 01:30 |
freemangordon | Wizzup: BlagovestPetrov[: do we have chimaera VM? Or, shall I install devuan image and add our repos? | 08:47 |
BlagovestPetrov[ | I have a local one on my pc | 09:07 |
freemangordon | lest or chimaera? | 09:08 |
freemangordon | *leste | 09:08 |
freemangordon | BlagovestPetrov[: did you hit "/usr/bin/ld: src/serialize.pic.o:./src/strbuf.h:82: multiple definition of `strbuftypetags'; src/strbuf.pic.o:./src/strbuf.h:82: first defined here" issue with alarmd? | 09:41 |
BlagovestPetrov[ | hm, nope | 09:42 |
BlagovestPetrov[ | I will try it again | 09:42 |
freemangordon | gcc version 10.2.1 20210110 (Debian 10.2.1-6) | 09:42 |
freemangordon | I think this: | 09:43 |
freemangordon | user@devuan:~/git/alarmd$ git diff | 09:43 |
freemangordon | diff --git a/src/states.inc b/src/states.inc | 09:43 |
freemangordon | index 374b519..72727fe 100644 | 09:43 |
freemangordon | --- a/src/states.inc | 09:43 |
freemangordon | +++ b/src/states.inc | 09:43 |
freemangordon | @@ -47,5 +47,7 @@ ALARM_STATE(DELETED) | 09:43 |
freemangordon | 09:43 | |
freemangordon | ALARM_STATE(FINALIZED) | 09:43 |
freemangordon | 09:43 | |
freemangordon | +ALARM_STATE(LAST) | 09:43 |
freemangordon | + | 09:43 |
freemangordon | # undef ALARM_STATE | 09:43 |
freemangordon | #endif | 09:43 |
freemangordon | should be the correct fix | 09:43 |
freemangordon | or, we don;t try to print like %s and do it %d | 09:44 |
freemangordon | ugh, github does not like patches in comments :( | 09:48 |
Wizzup | freemangordon: use three backticks | 09:59 |
Wizzup | for comments | 09:59 |
freemangordon | https://github.com/maemo-leste/alarmd/pull/3 | 10:00 |
freemangordon | not that I am able to build in chimaera VM, but this fixes the particular issue | 10:00 |
Wizzup | freemangordon: wrt vm, I set up a devuan chimaera server vm | 10:00 |
Wizzup | iirc | 10:00 |
freemangordon | I did netinstall | 10:00 |
Wizzup | right | 10:00 |
freemangordon | and added leste repos | 10:00 |
Wizzup | and then add maemo keyring pkg with dpkg | 10:01 |
freemangordon | right | 10:01 |
Wizzup | and then add repos | 10:01 |
freemangordon | but, this particular package fails with "/usr/bin/ld: src/serialize.pic.o:./src/strbuf.h:82: multiple definition of `strbuftypetags'; src/strbuf.pic.o:./src/strbuf.h:82: first defined here" | 10:01 |
Wizzup | I am still waking up | 10:01 |
Wizzup | you probably did the right thing, but I can check in 25 mins or so | 10:01 |
Wizzup | the linker clearly acts a bit different again :D | 10:02 |
freemangordon | seems that headers is included by 2 files | 10:02 |
Wizzup | maybe some ifdef changes | 10:02 |
freemangordon | no | 10:02 |
freemangordon | we either has to typedef ar mark as static | 10:03 |
freemangordon | *or mark | 10:03 |
freemangordon | there *is* issue and linker correctly complains | 10:03 |
freemangordon | yeah, removing variable declaration from the header fixes it | 10:05 |
BlagovestPetrov[ | freemangordon | 10:05 |
BlagovestPetrov[ | seems that headers is included by 2 files | 10:05 |
freemangordon | yep | 10:05 |
BlagovestPetrov[ | oh, yes. I remember this issue from yesterday | 10:05 |
freemangordon | I just wonder what the initial intend was | 10:06 |
freemangordon | I would say they wanted 'typedef enum blah {...} blah;", but ... | 10:06 |
freemangordon | BlagovestPetrov[: please test with https://github.com/maemo-leste/alarmd/pull/3/commits/034e3d9b187997cce6deea07bef644933e560785 and LMK | 10:09 |
freemangordon | either /me or Wizzup will merge once you confirm this fixes the issue | 10:09 |
BlagovestPetrov[ | ok | 10:11 |
BlagovestPetrov[ | it's ok for me | 10:20 |
Wizzup | freemangordon: are you ok with ignoring the gtk deprecation warnings? (I am) | 10:36 |
freemangordon | yes | 11:23 |
freemangordon | but, instead of fixing all the packages, I think gtk pkgconfig cflags shall be fixed | 11:23 |
Wizzup | that smells hacky to me | 11:39 |
Wizzup | hm libhildon1-dev depends on libhildon1 which depends on osso-sounds | 11:39 |
Wizzup | osso-sounds-ui | 11:40 |
Wizzup | I guess I will have to these next them | 11:40 |
Wizzup | then* | 11:40 |
Wizzup | bleh | 11:40 |
BlagovestPetrov[ | yeah, I've installed osso-sounds directly from Beowulf on my VM | 11:47 |
BlagovestPetrov[ | https://hastebin.com/pebiqoqija.diff | 11:48 |
BlagovestPetrov[ | fyi, my notes until now :) | 11:48 |
BlagovestPetrov[ | ++ | 11:52 |
BlagovestPetrov[ | osso-systemui-modechange | 11:52 |
BlagovestPetrov[ | osso-systemui-modechange-dev | 11:52 |
BlagovestPetrov[ | they are both ok, without any modifications | 11:52 |
BlagovestPetrov[ | + libdevlock | 11:58 |
BlagovestPetrov[ | ilibdevlock-bin - functions for validating and changing the lock code -- binaries | 11:58 |
BlagovestPetrov[ | libdevlock-dbg - functions for validating and changing the lock code | 11:58 |
BlagovestPetrov[ | libdevlock-dev - functions for validating and changing the lock code | 11:58 |
BlagovestPetrov[ | libdevlock1 - functions for validating and changing the lock code | 11:58 |
BlagovestPetrov[ | these are the packages from libdevlock | 11:58 |
BlagovestPetrov[ | but osso-systemui-devlock build-depends on libdevlock1-dev, not libdevlockdeb | 11:58 |
BlagovestPetrov[ | should I change in the control? | 11:59 |
Wizzup | BlagovestPetrov[: fyi keep an eye also on the bug tracker issue | 12:00 |
Wizzup | I did for example theme cacher | 12:00 |
Wizzup | and also already did the dh10 port | 12:00 |
Wizzup | yesterday or so | 12:00 |
Wizzup | otherwise this looks great ty | 12:00 |
BlagovestPetrov[ | yeah, i'm following it :) | 12:12 |
BlagovestPetrov[ | libdevlock is ok, forget about it | 12:30 |
BlagovestPetrov[ | Wizzup: https://cloud.petrovs.info/s/8cpTZFEP5ma92Tr here is better than in hastebin :) | 12:50 |
Wizzup | yup | 12:52 |
Wizzup | raw txt is even better :P | 12:52 |
Wizzup | I assume you'll update this one? | 12:52 |
BlagovestPetrov[ | yeah | 12:56 |
BlagovestPetrov[ | the new file template was markdown by default | 12:57 |
Wizzup | query e3 | 12:57 |
BlagovestPetrov[ | it's still raw :) | 12:57 |
Wizzup | oops | 12:57 |
Wizzup | ok, I almost have a script to find pkgs we still need to import | 13:05 |
Wizzup | freemangordon: https://github.com/maemo-leste/bugtracker/issues/644#issuecomment-1327420442 | 13:16 |
Wizzup | not that many | 13:16 |
Wizzup | (and some of them are from ascii or no longer relevant) | 13:20 |
Wizzup | so do we just import, or do we put this in a repo somehow? | 13:20 |
Wizzup | shall I make clockd-settings-mr0 from the pkg? | 13:37 |
Wizzup | it's really just etc/clockd/clockd-settings.default | 13:39 |
Wizzup | might as well put that in the clockd pkg? | 13:39 |
Wizzup | freemangordon: when you're back, do we import, or some other path? | 13:46 |
Wizzup | I guess I can import now | 13:46 |
Wizzup | and we can remove it later | 13:46 |
Wizzup | done | 13:53 |
Wizzup | freemangordon: ok libhildondesktop also failed for GTimeVal, that is kinda annoying, but I am still not sure if changing gtk pkgcnfig flags is the best hting | 13:56 |
Wizzup | I suppose we could, but meh | 13:56 |
BlagovestPetrov[ | it's just a warning | 13:56 |
Wizzup | no, the CI builds with -Werror somehow | 13:57 |
Wizzup | https://phoenix.maemo.org/job/libhildondesktop-binaries/architecture=arm64,label=arm64/14/consoleText | 13:57 |
Wizzup | BlagovestPetrov[: so configure.ac of libhildondesktop -definitely- passes -Werror | 14:01 |
Wizzup | CFLAGS="$CFLAGS -Wall -Wmissing-prototypes -Wmissing-declarations -Werror -Wno-format-extra-args -DG_DISABLE_CAST_CHECKS" | 14:01 |
Wizzup | BlagovestPetrov[: I just checked out libhildondesktop on my vm and I also see the error there | 14:02 |
Wizzup | oh, I see it's not on your list | 14:02 |
Wizzup | ok, so I now get it I guess | 14:03 |
Wizzup | so we can put -Wno-error=deprecated-declarations in some pkgs then | 14:03 |
Wizzup | putting it in gtk won't help if pkgs pass -Werror after that (iiuc) | 14:03 |
BlagovestPetrov[ | I had another problem with libhildondesktop | 14:06 |
BlagovestPetrov[ | it depends on iphb which depends on iphb-dkms | 14:07 |
BlagovestPetrov[ | *iphbd | 14:07 |
Wizzup | only for install | 14:07 |
Wizzup | this is at build time | 14:07 |
Wizzup | at least apt-get build-dep just worked for me | 14:08 |
Wizzup | but yeah if we have to patch like every gtk pkg we have that uses Werror for this, we should take a moment | 14:08 |
BlagovestPetrov[ | I think that this is ok. These packages must be upgraded to a newer GTK anyway | 14:10 |
Wizzup | are you sure you want to make 100 pull requests just to add an extra flag? | 14:13 |
Wizzup | everything has to move to gtk3 at once, it's not a one-by-one thing | 14:14 |
Wizzup | so that's probably a year out at least, probably more | 14:14 |
Wizzup | I'm lazy and I think it's not productive to add the flag everywhere if it's not actually fixing anything :D | 14:15 |
Wizzup | but I don't want to remove Werror for it either | 14:15 |
Wizzup | uvos: I do feel that power usage might be higher on new kernel? | 14:25 |
freemangordon | Wizzup: ok, maybe not pkgconfig, but there might be some gtk macro we can pass through Ci CFLAGS | 14:26 |
Wizzup | yes, but it then just depends on the order pkgconfig is called | 14:28 |
Wizzup | in the configure.ac or Makefile | 14:28 |
freemangordon | no, I mean a flag that removes deprectaed attribute to those functions | 14:29 |
Wizzup | ok | 14:29 |
Wizzup | right | 14:29 |
freemangordon | but, can't look at it ATM | 14:29 |
Wizzup | same, bbiab | 14:30 |
BlagovestPetrov[ | I was expecting ~50 pull requests :D | 14:30 |
freemangordon | oh, wait, this ig glib | 14:30 |
freemangordon | *is | 14:30 |
freemangordon | not gtk | 14:30 |
freemangordon | BTW, we must distribute our own glib either ways | 14:30 |
freemangordon | so removing deprecated attribute should not be an issue | 14:31 |
freemangordon | ttyl | 14:31 |
Wizzup | freemangordon: we still need our own? | 14:52 |
Wizzup | freemangordon: so should I look at some compiler flag for this? | 15:47 |
freemangordon | Wizzup: yes, I think so, I doubt my patch was backported | 17:03 |
Wizzup | ok | 17:22 |
Wizzup | so how do we move forward? | 17:50 |
freemangordon | Wizzup: sorry, I have guests | 20:52 |
Wizzup | np | 21:00 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!