libera/#maemo-leste/ Saturday, 2022-11-26

BlagovestPetrov[https://github.com/maemo-leste/osso-systemui/pull/2 :))01:00
BlagovestPetrov[https://github.com/maemo-leste/osso-systemui-powerkeymenu/pull/201:14
BlagovestPetrov[https://github.com/maemo-leste/osso-systemui-tklock/pull/301:29
BlagovestPetrov[I'll continue with the rest of systemui packages tomorrow, if you aggree that ignoring the GTK warnings is ok01:30
freemangordonWizzup: BlagovestPetrov[: do we have chimaera VM? Or, shall I install devuan image and add our repos?08:47
BlagovestPetrov[I have a local one on my pc09:07
freemangordonlest or chimaera?09:08
freemangordon*leste09:08
freemangordonBlagovestPetrov[: did you hit "/usr/bin/ld: src/serialize.pic.o:./src/strbuf.h:82: multiple definition of `strbuftypetags'; src/strbuf.pic.o:./src/strbuf.h:82: first defined here" issue with alarmd?09:41
BlagovestPetrov[hm, nope09:42
BlagovestPetrov[I will try it again09:42
freemangordongcc version 10.2.1 20210110 (Debian 10.2.1-6)09:42
freemangordonI think this:09:43
freemangordonuser@devuan:~/git/alarmd$ git diff09:43
freemangordondiff --git a/src/states.inc b/src/states.inc09:43
freemangordonindex 374b519..72727fe 10064409:43
freemangordon--- a/src/states.inc09:43
freemangordon+++ b/src/states.inc09:43
freemangordon@@ -47,5 +47,7 @@ ALARM_STATE(DELETED)09:43
freemangordon09:43
freemangordon ALARM_STATE(FINALIZED)09:43
freemangordon09:43
freemangordon+ALARM_STATE(LAST)09:43
freemangordon+09:43
freemangordon # undef ALARM_STATE09:43
freemangordon #endif09:43
freemangordonshould be the correct fix09:43
freemangordonor, we don;t try to print like %s and do it %d09:44
freemangordonugh, github does not like patches in comments :(09:48
Wizzupfreemangordon: use three backticks09:59
Wizzupfor comments09:59
freemangordonhttps://github.com/maemo-leste/alarmd/pull/310:00
freemangordonnot that I am able to build in chimaera VM, but this fixes the particular issue10:00
Wizzupfreemangordon: wrt vm, I set up a devuan chimaera server vm10:00
Wizzupiirc10:00
freemangordonI did netinstall10:00
Wizzupright10:00
freemangordonand added leste repos10:00
Wizzupand then add maemo keyring pkg with dpkg10:01
freemangordonright10:01
Wizzupand then add repos10:01
freemangordonbut, this particular package fails with "/usr/bin/ld: src/serialize.pic.o:./src/strbuf.h:82: multiple definition of `strbuftypetags'; src/strbuf.pic.o:./src/strbuf.h:82: first defined here"10:01
WizzupI am still waking up10:01
Wizzupyou probably did the right thing, but I can check in 25 mins or so10:01
Wizzupthe linker clearly acts a bit different again :D10:02
freemangordonseems that headers is included by 2 files10:02
Wizzupmaybe some ifdef changes10:02
freemangordonno10:02
freemangordonwe either has to typedef ar mark as static10:03
freemangordon*or mark10:03
freemangordonthere *is* issue and linker correctly complains10:03
freemangordonyeah, removing variable declaration from the header fixes it10:05
BlagovestPetrov[freemangordon10:05
BlagovestPetrov[seems that headers is included by 2 files10:05
freemangordonyep10:05
BlagovestPetrov[oh, yes. I remember this issue from yesterday10:05
freemangordonI just wonder what the initial intend was10:06
freemangordonI would say they wanted 'typedef enum blah {...} blah;", but ...10:06
freemangordonBlagovestPetrov[: please test with https://github.com/maemo-leste/alarmd/pull/3/commits/034e3d9b187997cce6deea07bef644933e560785 and LMK10:09
freemangordoneither /me or Wizzup will merge once you confirm this fixes the issue10:09
BlagovestPetrov[ok10:11
BlagovestPetrov[it's ok for me10:20
Wizzupfreemangordon: are you ok with ignoring the gtk deprecation warnings? (I am)10:36
freemangordonyes11:23
freemangordonbut, instead of fixing all the packages, I think gtk pkgconfig cflags shall be fixed11:23
Wizzupthat smells hacky to me11:39
Wizzuphm libhildon1-dev depends on libhildon1 which depends on osso-sounds11:39
Wizzuposso-sounds-ui11:40
WizzupI guess I will have to these next them11:40
Wizzupthen*11:40
Wizzupbleh11:40
BlagovestPetrov[yeah, I've installed osso-sounds directly from Beowulf on my VM11:47
BlagovestPetrov[https://hastebin.com/pebiqoqija.diff11:48
BlagovestPetrov[fyi, my notes until now :)11:48
BlagovestPetrov[++11:52
BlagovestPetrov[osso-systemui-modechange11:52
BlagovestPetrov[osso-systemui-modechange-dev11:52
BlagovestPetrov[they are both ok, without any modifications11:52
BlagovestPetrov[+ libdevlock11:58
BlagovestPetrov[ilibdevlock-bin - functions for validating and changing the lock code -- binaries11:58
BlagovestPetrov[libdevlock-dbg - functions for validating and changing the lock code11:58
BlagovestPetrov[libdevlock-dev - functions for validating and changing the lock code11:58
BlagovestPetrov[libdevlock1 - functions for validating and changing the lock code11:58
BlagovestPetrov[these are the packages from libdevlock11:58
BlagovestPetrov[but osso-systemui-devlock build-depends on libdevlock1-dev, not libdevlockdeb11:58
BlagovestPetrov[should I change in the control?11:59
WizzupBlagovestPetrov[: fyi keep an eye also on the bug tracker issue12:00
WizzupI did for example theme cacher12:00
Wizzupand also already did the dh10 port12:00
Wizzupyesterday or so12:00
Wizzupotherwise this looks great ty12:00
BlagovestPetrov[yeah, i'm following it :)12:12
BlagovestPetrov[libdevlock is ok, forget about it12:30
BlagovestPetrov[Wizzup: https://cloud.petrovs.info/s/8cpTZFEP5ma92Tr here is better than in hastebin :)12:50
Wizzupyup12:52
Wizzupraw txt is even better :P12:52
WizzupI assume you'll update this one?12:52
BlagovestPetrov[yeah12:56
BlagovestPetrov[the new file template was markdown by default12:57
Wizzupquery e312:57
BlagovestPetrov[it's still raw :)12:57
Wizzupoops12:57
Wizzupok, I almost have a script to find pkgs we still need to import13:05
Wizzupfreemangordon: https://github.com/maemo-leste/bugtracker/issues/644#issuecomment-132742044213:16
Wizzupnot that many13:16
Wizzup(and some of them are from ascii or no longer relevant)13:20
Wizzupso do we just import, or do we put this in a repo somehow?13:20
Wizzupshall I make clockd-settings-mr0 from the pkg?13:37
Wizzupit's really just etc/clockd/clockd-settings.default13:39
Wizzupmight as well put that in the clockd pkg?13:39
Wizzupfreemangordon: when you're back, do we import, or some other path?13:46
WizzupI guess I can import now13:46
Wizzupand we can remove it later13:46
Wizzupdone13:53
Wizzupfreemangordon: ok libhildondesktop also failed for GTimeVal, that is kinda annoying, but I am still not sure if changing gtk pkgcnfig flags is the best hting13:56
WizzupI suppose we could, but meh13:56
BlagovestPetrov[it's just a warning13:56
Wizzupno, the CI builds with -Werror somehow13:57
Wizzuphttps://phoenix.maemo.org/job/libhildondesktop-binaries/architecture=arm64,label=arm64/14/consoleText13:57
WizzupBlagovestPetrov[: so configure.ac of libhildondesktop -definitely- passes -Werror14:01
WizzupCFLAGS="$CFLAGS -Wall -Wmissing-prototypes -Wmissing-declarations -Werror -Wno-format-extra-args -DG_DISABLE_CAST_CHECKS"14:01
WizzupBlagovestPetrov[: I just checked out libhildondesktop on my vm and I also see the error there14:02
Wizzupoh, I see it's not on your list14:02
Wizzupok, so I now get it I guess14:03
Wizzupso we can put  -Wno-error=deprecated-declarations in some pkgs then14:03
Wizzupputting it in gtk won't help if pkgs pass -Werror after that (iiuc)14:03
BlagovestPetrov[I had another problem with libhildondesktop14:06
BlagovestPetrov[it depends on iphb which depends on iphb-dkms14:07
BlagovestPetrov[*iphbd14:07
Wizzuponly for install14:07
Wizzupthis is at build time14:07
Wizzupat least apt-get build-dep just worked for me14:08
Wizzupbut yeah if we have to patch like every gtk pkg we have that uses Werror for this, we should take a moment14:08
BlagovestPetrov[I think that this is ok. These packages must be upgraded to a newer GTK anyway14:10
Wizzupare you sure you want to make 100 pull requests just to add an extra flag?14:13
Wizzupeverything has to move to gtk3 at once, it's not a one-by-one thing14:14
Wizzupso that's probably a year out at least, probably more14:14
WizzupI'm lazy and I think it's not productive to add the flag everywhere if it's not actually fixing anything :D14:15
Wizzupbut I don't want to remove Werror for it either14:15
Wizzupuvos: I do feel that power usage might be higher on new kernel?14:25
freemangordonWizzup: ok, maybe not pkgconfig, but there might be some gtk macro we can pass through Ci CFLAGS14:26
Wizzupyes, but it then just depends on the order pkgconfig is called14:28
Wizzupin the configure.ac or Makefile14:28
freemangordonno, I mean a flag that removes deprectaed attribute to those functions14:29
Wizzupok14:29
Wizzupright14:29
freemangordonbut, can't look at it ATM14:29
Wizzupsame, bbiab14:30
BlagovestPetrov[I was expecting ~50 pull requests :D14:30
freemangordonoh, wait, this ig glib14:30
freemangordon*is14:30
freemangordonnot gtk14:30
freemangordonBTW, we must distribute our own glib either ways14:30
freemangordonso removing deprecated attribute should not be an issue14:31
freemangordonttyl14:31
Wizzupfreemangordon: we still need our own?14:52
Wizzupfreemangordon: so should I look at some compiler flag for this?15:47
freemangordonWizzup: yes, I think so, I doubt my patch was backported17:03
Wizzupok17:22
Wizzupso how do we move forward?17:50
freemangordonWizzup: sorry, I have guests20:52
Wizzupnp21:00

Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!