| steev | cornelius: i have a proper fix for the led overlay | 20:49 |
|---|---|---|
| steev | was so silly, til it was explained to me | 20:49 |
| steev | https://github.com/steev/linux/commit/84c27b317045cd41a4bc1d748a49c59ec817e51f | 20:51 |
| steev | phandles aren't guaranteed, so, do it this way and no matter what the phandle, it should work | 22:18 |
| steev | that's also why it was different between 5.10 and 5.16 | 22:19 |
| cornelius | steev: looks pretty much the same except you have the includes and ur not using hexadecimals or am I missing something? | 22:19 |
| steev | that's exactly what it is | 22:19 |
| steev | it's just "correct" instead of using hex | 22:19 |
| cornelius | The reason I didn't use includes and also used hexadecimals is because it would error on me when I compiled it outside of the source tree. I think? | 22:21 |
| steev | hm, maybe | 22:21 |
| steev | i haven't tried that | 22:21 |
| cornelius | Either way looks good | 22:22 |
| steev | and no need to compile it outside the tree now ;) | 22:22 |
| cornelius | very true | 22:22 |
| cornelius | I'll have to include it in my overlay patch. | 22:23 |
| cornelius | I'm pretty sure this really doesn't need to be there either: `compatible = "radxa,zero", "amlogic,g12a";` | 22:23 |
| cornelius | I just add it because its `correct` | 22:23 |
| cornelius | 99% sure it works without it | 22:24 |
| steev | yeah it should work, but i believe with that there, it won't run if you try to load it on !radxa,zero or !amlogic,g12a | 22:24 |
| steev | haven't tried | 22:24 |
| cornelius | yeah exactly. thats whats its for I believe | 22:24 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!