libera/#maemo-leste/ Thursday, 2021-12-23

Wizzuprafael2k: what issues do you see in firefox00:06
uvosdose clutter 1.0 still perform terribly00:09
uvosor did it just hit the problem in the old ddk's where they ended up copying the frame on the cpu00:09
uvoslike gears00:09
Wizzupuvos: most likely still performs terrible00:10
Wizzupuvos: so they asked for apitrace00:10
Wizzupand the virtual keyboard problems where stuff is not visible *disappears* under apitrace00:10
Wizzupuvos: rafael2k: hey, did we actually try glamor with llvmpipe?00:13
Wizzupor did we only try to disable glamor alltogether?00:13
uvosglamor was disabled00:14
uvosbut its not glamors fault since it works on glamor00:14
uvoswhenever hildon is not rendering00:14
uvosglamor dose _more_work00:14
Wizzupfirefox also has no glitches with apitrace00:14
uvosie when you disable composistion00:14
uvosthen glamor has more work to do00:14
WizzupI guess this counts as heisenbug then00:17
Wizzupfreemangordon: wouldn't mind to pick your brain on this tomorrow00:24
_inkyas another method to test things i can suggest trying to run frozen-bubble from debian repos. it'll require bt keyboard though.00:51
Wizzupwhat do you see?00:53
rafael2kWizzup: crazy re-drawings in firefox... it looks like its dimensions keep changing, even not scrolling the page the ui elements are drawn in wrong places, then in correct places, then in wrong again...07:37
rafael2kWizzup: dont really know how to try glamor with llvmpipe...07:39
Wizzuprafael2k: ok, yes11:29
Wizzuprafael2k: I am also not seeing that anymore with apitrace11:29
uvosglamor refuses to enable on llvmpipe, you have to comment out that check in the source12:47
uvosnot sure why you would want to in this case tho12:47
uvosthe problem seams not to be glamor12:47
Wizzupuvos: ok, I just want to be able to communicate that to them somehow, they didn't ask if it was glamor12:51
Wizzupuvos: but if the major problem goes away in apitrace ...12:51
uvosapitrace slows things down so i gues that helps somehow12:54
uvos:(12:54
Wizzupyes, to which the guy who responded to me said 'we have never seen timing problems so that seems unlikely to me'12:54
WizzupI guess I can make a video for them12:55
uvosWizzup: if you want to try llvm on glamor anyhow: https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/glamor/glamor_egl.c#L105612:56
uvosjust set GALLIUM_DRIVER to llvmpipe for xorg12:57
uvosthen you have llvm for glamor and lima for everything else12:57
uvosbut if api trace helps12:57
uvosthat might help to just because glamor will block forever copying the window pixmap to cpu12:57
uvosso im not sure how usefull it is12:58
uvosruning just hildon/clutter toys on llvm seams more likely to provide information12:58
WizzupI am not sure what you are suggesting exactly13:00
uvosrun hildon (or better some simple application that shows the problem on its own) on llvmpipe while glamor is lima acceleratated13:00
uvosresult: glamor exonerated13:00
uvos(problem dissapears)13:01
Wizzupok13:01
uvoswho is they btw13:01
uvosdo we have a open bug report?13:01
Wizzupno, I went to #lima on OFTC (you need to register and verify to talk) and asked how to best submit a bug report13:02
Wizzupso running h-d with LIBGL_ALWAYS_SOFTWARE=1 GALLIUM_DRIVER=llvmpipe makes it slow (as expected) and the issues seem to disappear as well13:05
uvosyeah as expected13:05
Wizzupdid you also see the gl errors I reported btw?13:06
uvosi did13:06
uvosdont really know what to make of it tho13:06
Wizzupthey seem to be related to textures13:06
uvosyes13:06
uvosit makes sense (with the issues you see)13:06
uvosit/that13:06
WizzupI think I found a way to reproduce the issue in apitrace13:07
uvosok13:08
uvosanoter reason why checking if you can find some simpler clutter applicaiton that shows this is good is because13:09
uvosmaybe this is somehting clutter fixed a long time ago13:10
Wizzupso just 'selecting' stuff in osso-xterm reproduces it13:10
uvosWizzup: ok13:10
Wizzupwant to see the traces?13:10
uvoscant hurt, but really i dont know mutch about gl.13:10
Wizzupjust to confirm they seem sensible to you13:11
Wizzupuvos: https://wizzup.org/dirlist/maemo-leste/lima/13:11
Wizzuphm it looks weird on llvmpipe too doesn't it... in the replay at least?13:12
WizzupI wish apitrace would be able to introduce a delay per frame13:13
Wizzupuvos: so frame per frame the trace of llvmpipe looks good to me13:16
Wizzupbut the replay is a mess13:16
Wizzupactually it's also a mess if I don't replay with LIBGL_ALWAYS_SOFTWARE on my *amd* gpu13:17
uvosso dose dump-images show the issue on lima13:17
uvoson that trace?13:17
Wizzupwell even my amdgpu driver shows it apparently :)13:17
Wizzupuvos: can you try to use apitrace and look at frame 47 and show me the contents?13:17
Wizzupof the llvmpipe one13:18
Wizzupqapitrace*13:18
WizzupI'll do ump images13:18
rafael2kwhat should do / patch to get battery level indication?13:18
Wizzuprafael2k: I linked you the patch13:18
Wizzuprafael2k: https://github.com/maemo-leste/pine64-kernel/commit/c62a8aeab344523190c7f539de60d94ba6c9cc5f13:18
Wizzupsomething like thisd13:18
rafael2ktks!13:18
Wizzupbut it's a hack13:18
rafael2kwhat isnt...13:18
rafael2k; )13:18
Wizzupuvos: ok let me get you dump-images commands13:19
uvosoh yeah13:19
uvosit looks wrong13:19
uvoseven on amdgpu13:19
Wizzupnow try LIBGL_ALWAYS_SOFTWARE=113:19
Wizzupin front of qapitrace13:19
uvosright thats fine13:19
uvosyeah so there seams to be a problem in clutter13:20
Wizzupor in various mesa drivers13:20
uvosthe gallium statetracker maybe13:21
uvossince thats shared13:21
uvosbut seams pretty unlikely13:21
uvosamdgpu gets into extreamly well tested teritorry13:21
rafael2kwhich kernel should I start from? https://github.com/maemo-leste/pine64-kernel/ ?13:21
rafael2k(I mean, which branch )13:22
Wizzupuvos: I mean supposedly this is good news13:23
uvosso is hildon-desktop clutter 1.0 something thats realtively easy to test13:23
uvosie dose it compile and work mostly?13:23
Wizzupnot super easy13:23
uvosok hmm13:24
Wizzupuvos: https://wizzup.org/dirlist/maemo-leste/lima/dump-images/13:29
rafael2kfrom which brach the actual kernel in the repo is coming from (for pp)?13:29
Wizzuprafael2k: sorry I saw the message but we're debugging the lima stuff and it's taking up my attention13:29
Wizzuprafael2k: the best thing always to do for maemo-leste repos is open the maemo/beowulf or maemo/beowulf-devel branch13:29
Wizzuplook at the debian/changelog file and see what tag it references13:30
Wizzupthat tag should lead you right to the branch13:30
Wizzupkeep in mind that -devel and non-devel can have different versions13:30
uvoskinda wierd that the lima trace has mesa complain about a bounch of errors13:31
uvosbut renders ok13:31
uvosand llvm trace is opisit13:31
Wizzuphm? both amdgpu renders seem off, of either trace, no?13:32
uvosamdgpu/radionsi rendering the lima trace is fine here13:32
uvosdont see anything wrong13:32
Wizzupdo you see cmd.txt in there?13:32
Wizzupcare to run that and compare?13:32
Wizzupoh13:33
WizzupI messed up the numbers there13:33
Wizzupfck13:33
Wizzupsec13:33
rafael2kWizzup: go ahead - lima++13:33
rafael2k; ))13:33
Wizzupuvos: care to look at cmd.txt now and try?13:34
Wizzupuvos: I bet it will look wrong for you13:34
uvosBAD: apitrace dump-images maemo-summoner-hildon-desktop-llvmpipe.trace -o llvmpipe-trace-amdgpu-redraw --calls=354213:35
uvosFINE: LIBGL_ALWAYS_SOFTWARE=1 apitrace dump-images maemo-summoner-hildon-desktop-llvmpipe.trace -o llvmpipe-trace-llvmpipe-redraw --calls=354213:35
uvosFINE + MESA ERRORS: apitrace dump-images maemo-summoner-hildon-desktop-lima.trace -o lima-trace-amdgpu-redraw --calls=235713:35
uvosFINE + MESA ERRORS: LIBGL_ALWAYS_SOFTWARE=1 apitrace dump-images maemo-summoner-hildon-desktop-lima.trace -o lima-trace-llvmpipe-redraw --calls=235713:36
Wizzupwhat image do you get on the lima-trace-amdgpu-redraw13:36
uvosall frames of the lima look fine13:36
uvosnot just that one13:36
Wizzuphttps://wizzup.org/dirlist/maemo-leste/lima/dump-images/lima-trace-amdgpu-redraw0000002357.png not this one then?13:36
uvoshttp://uvos.xuz/maserati/lima-trace-amdgpu-redraw0000002357.png13:37
uvos*xyz13:37
Wizzupdoes this still need an ip?13:38
uvosno13:38
Wizzupoh btw my images were weird because my vm resized the windows lmao13:38
uvosyour browser put www on it13:38
Wizzupinteresting @ your image13:38
WizzupI get this: https://wizzup.org/dirlist/maemo-leste/lima/dump-images/lima-trace-amdgpu-redraw0000002357.png13:39
uvoswierd13:39
Wizzupmaybe you have tearfree set or something :)13:39
uvosno13:39
Wizzupfreemangordon: I think we have a clutter bug on our hands13:39
Wizzupuvos: so I think at this point it's probably safe to say this seems buggy with most mesa drivers except for llvmpipe and with powervr13:40
uvoswell llvm makes sense13:40
uvosits extreamly forgiving with using wrong buffers etc since its dosen have hw caches and sutch13:41
WizzupI can confirm I also see errors only with the lima trace13:41
uvospowervr is not really a mesa driver anyhow13:42
uvosanything that affects this is implemented in the blobs13:42
uvosso eh13:42
Wizzupright13:42
Wizzupmy point was mostly that clearly it works on some drivers13:42
uvosright13:42
Wizzupuvos: I'll make a trace on my d413:46
Wizzupjust to see if that replays ok in mesa13:47
Wizzupuvos: btw any idea how to make apitrace replay delay images13:47
uvoshmm13:47
uvoswhat are you tring to acive13:48
uvosa video in real time?13:48
Wizzupyeah, that would be nice...13:48
uvosjust assemble the images with ffmpeg13:48
WizzupI cannot see anything really with 'replay'13:48
Wizzupyeah ok13:48
WizzupI just suspected that replay could do this somehow13:48
Wizzuplol apitrace segfaults with powervr drivers13:50
uvosheh13:51
uvosprobubly pvrtrace13:51
uvosis what you need to use13:51
uvosbut then you cant replay13:51
WizzupThread 1 "maemo-summoner" received signal SIGSEGV, Segmentation fault.13:51
Wizzup0xb4512662 in ?? () from /usr/lib/arm-linux-gnueabihf/libGLESv2_PVR_MESA.so13:51
Wizzupso I think the code that errors/warns with invalid enum is in clutter-0.8 debian/patches/02-eglx-backend-tfp.patch13:53
rafael2kbtw, the power patch is incomplete, this is why... https://github.com/maemo-leste/pine64-kernel/blob/maemo/beowulf-devel/debian/patches/0002-axp20x_battery-hardcode-technology-to-lion-for-now.patch13:53
Wizzuprafael2k: ah it was not rebased ok?13:53
rafael2kshould be: https://github.com/maemo-leste/pine64-kernel/commit/c62a8aeab344523190c7f539de60d94ba6c9cc5f13:53
Wizzupparazyd: ayyyy ^13:54
rafael2kWizzup: patch is missing an important part...13:54
Wizzuprafael2k: yeah I think parazyd rebased it and missed that property13:54
rafael2kuhum13:54
Wizzupor I did, idk, it's been a while13:54
rafael2kanyway, telephony is missing also, but that is just config tweaking13:54
rafael2kalso crypto...13:55
Wizzuprafael2k: yes, maybe summarise it an issue13:55
WizzupI am waiting for parazyd to do it since I have too much on my hands already with n900 and droid4 kernel13:55
uvoshttp://uvos.xyz/maserati/lima-trace-amdgpu-redraw.mp413:55
uvoslooks really fun :P13:55
Wizzupthat's pretty accurate probably13:56
Wizzupalthough I am not sure if I saw the h-d background bleed througfh13:56
uvosits running at 1/2 realtime speed13:56
uvosso13:57
uvospobubly harder to see in real time13:57
WizzupI think this is beyond something I can just solve right now13:57
Wizzup(as in, I am going to take a break)13:57
WizzupI think it might be best to check with freemangordon when he gets back, since he's most knowledgeable about clutter13:57
WizzupIt's been about 8 years since I made my last opengl program in uni ;)13:57
rafael2kWizzup: ok13:58
uvosi have never touched any code in a professional or academic capacity - dont look at me :P13:58
Wizzupuvos: yeah so there are only three places that at least cause the error/invalid enum13:59
Wizzup$ grep -r GL_TEXTURE_2D . | grep glEnable13:59
Wizzupgrep: ./.git/objects/pack/pack-829b37b8f8e1f79230c4ad5ee45798bf4de51ebb.pack: binary file matches13:59
uvoslink?13:59
Wizzup./clutter/cogl/common/cogl-pvr-texture-gl.c:      GE( glEnable(GL_TEXTURE_2D) );13:59
Wizzup./clutter/eglx/clutter-eglx-texture-pixmap.c:  glEnable (GL_TEXTURE_2D);13:59
Wizzup./debian/patches/02-eglx-backend-tfp.patch:+  glEnable (GL_TEXTURE_2D);13:59
Wizzupwell, it's clutter 0.8 repo13:59
Wizzuprafael2k: I can maybe do a build later today or tomorrow, esp if you suggest the config changes, but let's see13:59
Wizzupuvos: https://github.com/maemo-leste-upstream-forks/clutter-0.813:59
Wizzupuvos: probably not this: https://github.com/maemo-leste-upstream-forks/clutter-0.8/commit/e66ff577333ed34329c5289838c2139c6cbd26ea14:00
Wizzupuvos: so it looks like some of the commits depends on a specific extension being present14:01
uvosmhm14:02
Wizzuplooking at https://github.com/maemo-leste-upstream-forks/clutter-0.8/commit/64c3f7a96d29effc5910331d57822d99b970d433 in particular14:02
Wizzupit could be that we just take the wrong unsupported path and that causes the enum issue perhaps14:02
uvosyes seams likely14:03
Wizzupalthough the glEnable is before that decision14:03
WizzupI think the clutter 0.8 patches might not get applied at all14:04
Wizzupthere doesn't seem to be a series file14:04
Wizzupbbiab14:05
uvosit also renders wrong on intel btw14:06
Wizzupso the lima guy said14:06
Wizzup13:42 < enunes> Wizzup: hmm I played it but I'm still not sure what am I looking at14:06
Wizzup13:43 < enunes> best case would be if a single trace reproduces the bug when played on the lima device and does not reproduce it on e.g. intel14:06
Wizzupwhich is why I wanted to try powervr14:07
Wizzupbut imho the llvmpipe trace should suffice14:07
WizzupI guess I could try to replay that on lima14:07
uvosits wrong on i965 too14:10
uvosso a bug in mesa is pretty unlikely14:10
uvos(i965 is a mesa classic dirver that shares very little with  the gallium drivers radionsi/lima)14:11
Wizzupso this on the pp:14:12
Wizzupapitrace replay maemo-summoner-hildon-desktop-llvmpipe.trace14:12
Wizzupshows the same problems14:12
Wizzupthis does not:14:12
WizzupLIBGL_ALWAYS_SOFTWARE=1 apitrace replay maemo-summoner-hildon-desktop-llvmpipe.trace14:12
Wizzupand actually the replay looks ok speed wise14:12
Wizzupish14:12
uvosheh14:12
Wizzupprobably because the gpu is slow :)14:13
uvoswell inky_ and rafael2k use hildon on llvmpipe on pp14:13
uvosso it must be okish sorta14:13
uvoscertenly llvmpipe hildon on d4 is more than painfull14:13
Wizzupit's all painful imho14:14
Wizzupbut ok14:14
Wizzupif you see just how butter smooth portrait h-d is with lima when it works :)14:14
Wizzupit's quite a sight14:14
Wizzupok now actually brb14:14
Wizzupso lima supports EGL_KHR_image_pixmap but llvmpipe does not14:52
uvosk14:53
Wizzupso perhaps the way we do EGL_KHR_image_pixmap is broken14:53
uvosyes14:53
Wizzup(even though it clearly works for pvr)14:53
uvossounds very possible14:53
uvosi would not count on pvr to enforce spec :P14:53
uvosso comment that path out and try on lima14:54
Wizzupit seemed to be more like mesa not following spec if I recall fmg correctly14:54
uvosyes what glamor did with khr image was ub14:54
uvosmesa just worked in this case14:55
Wizzupok14:55
Wizzupbtw lima has EGL_NOK_texture_from_pixmap not we search for something else14:55
Wizzupwe search for EGL_NOKIA_texture_from_pixmap14:55
Wizzupfreemangordon: ^^^14:56
Wizzuppvr also as EGL_NOK_texture_from_pixmap it seems14:57
Wizzupddk 1.17 at least14:57
Wizzupprobably need to update that check too then14:57
Wizzupwondering if the call to eglCreateImageKHR perhaps needs updated img attribs14:59
Wizzupwell hang on, why does the llvmpipe path still fail for lima then14:59
Wizzupmaybe they interpret the KHR properties differently14:59
WizzupEGL_KHR_partial_update seems to be in lima but not in pvr15:00
Wizzupso setting use_fallback=1 I think helps with firefox corruption, but not at all with osso-xterm problems I was tracing15:11
Wizzupbut it does make vkb just work I think15:11
Wizzupwe're onto something :)15:12
Wizzupchecking for EGL_NOK_texture_from_pixmap instead of EGL_NOKIA_texture_from_pixmap has different behavious as well, the status area looks odd/off, and the other problems remain15:14
Wizzupso the current workaround is to set use_fallback to TRUE15:14
Wizzupthere seems to be more problems still though15:17
Wizzupyeah no this is not the fix for some of the other problems at least15:19
Wizzupuvos: do you recall the obnoxious glib variable to print g_debug messages?15:24
WizzupG_MESSAGES_DEBUG=all it is15:25
Wizzupmaybe the problem is in clutter_eglx_texture_pixmap_update_area15:27
Wizzupthis is beyond me for now15:38
freemangordonhmm?15:58
freemangordonseems I am missing the party :)15:58
freemangordonWizzup: did you apply "glamor: add missing GL_TEXTURE_WRAP_X parameters"?15:59
freemangordonhmm, where do you see EGL_NOK_texture_from_pixmap?16:01
Wizzupfreemangordon: hi!16:01
Wizzuplet's take a step back a for a moment16:02
freemangordonsorry, I was too busy, I have some 30 minutes maybe now and I'll have to run (GF has birthday :) )16:02
freemangordonok16:02
Wizzupok16:02
Wizzupcongrats :)16:02
freemangordonthanks!16:02
Wizzupso we're seeing lots of flickering and drawing of old and invalid content on the pinephone16:02
freemangordonso, if I can help, go ahead16:02
Wizzupthis manifests itself in a few ways:16:02
Wizzup1. firefox flickers badly16:02
Wizzup2. osso-xterm selection (with finger) renders wrongly and flickers intensely16:03
Wizzup3. vkb doesn't render most of its content16:03
Wizzupthere are a few more, like scrolling in most windows is SNAFU16:03
freemangordon..and this gets fixed with no compositing16:03
freemangordon(I have read the backscroll)16:03
freemangordonso, it seems we suspect TFP now, correct?16:04
WizzupI am not sure if this is entirely true wrt compositing16:04
Wizzupthere might be several problems16:04
Wizzupjust to add a few more bugs/problems:16:04
freemangordonBTW, if we misuse TFP, that might explain tearing we see on d4 with pvr16:04
Wizzup4. title bars also often switch back and forth and even get some weird rotation angle16:04
freemangordonught16:05
freemangordon*ugh16:05
Wizzupthis is all gone when we use llvmpipe16:05
Wizzupall of the problems just disappear16:05
Wizzupllvmpipe however doesn't support TFP so it uses the fallback x11 path16:05
freemangordonmhm16:05
Wizzupthis is replay with llvmpipe: https://wizzup.org/dirlist/maemo-leste/lima/dump-images/llvmpipe-trace-llvmpipe-redraw0000003542.png16:05
Wizzupthis is with my laptop amd mesa: https://wizzup.org/dirlist/maemo-leste/lima/dump-images/llvmpipe-trace-amdgpu-redraw0000003542.png16:06
freemangordonone note re TFP - it is supported in VMs, so I doublt we misuse it16:06
WizzupVMs are mostly llvmpipe16:06
Wizzupbut well noted16:06
freemangordonnot really16:06
Wizzupyou can see the amd mesa one is clearly wrong16:06
freemangordonat least vmware and virtualbox provide 3d accell16:06
freemangordonright16:06
freemangordonbut doesn;t seem like bad texture to me16:07
Wizzupthere seem to be a pattern to it when I look at it in apitrace, the regions that were previously rendered black get turned white again in later frames16:07
freemangordonsoemthing doesn;t get flushed?16:07
Wizzuppossible16:07
Wizzupbut note that X renders with glamor16:07
Wizzupand it works just fine when h-d is llvmpipe but X is lima16:07
Wizzupas far as I can tell16:08
WizzupI haven't tested the opposite (glamor with llvmpipe and h-d with lima)16:08
freemangordonright, but then buffers are not allocated by lima driver16:08
freemangordonBOs that is16:08
Wizzupok16:08
Wizzupso there are a few other things to note:16:08
Wizzup1. not super relevant but the NOKIA extension we search for is present in mesa as NOK not NOKIA16:09
Wizzup2. mesa complains about invalid enums in glEnable(GL_TEXTURE_2D) and some texture param calls16:09
freemangordon(this is new to me, was not there few months ago)16:09
freemangordon(16,59,40) freemangordon: Wizzup: did you apply "glamor: add missing GL_TEXTURE_WRAP_X parameters"?16:09
Wizzup3. if I set use_fallback = TRUE with lima ( so the TFP checks are ommitted), some things work fine, but not all problems are solved, suggesting there are problems beyond TFP16:10
freemangordonso, did you apply that patch?16:10
Wizzupfreemangordon: yes, looks like I have those applied16:10
freemangordonthis is the 3rd one16:10
Wizzupyes16:10
freemangordonok16:10
Wizzupthis is basically where I am at now16:11
freemangordonI doubt we break TFP, clutter just issues 2 or 3 EGL calls16:11
WizzupI am going to check how it goes with h-d using lima, but tfp hard disabled, I want to see if the osso-xterm selection bug is still there then16:11
freemangordonok16:12
Wizzupso no, with TFP fallback in place, that redrawing bug is still there16:12
freemangordonas expected16:13
Wizzupbut some bugs are fixed (like virtual keyboard rendering)16:13
freemangordonmaybe because of the changed timing16:13
Wizzupcould be16:13
Wizzupfirefox also doesn't flicker as much anymore16:13
Wizzupin any case there is where I am stuck16:13
freemangordonso, what I think is - some fence is missing16:13
Wizzupthe traces clearly render wrong on mesa16:14
freemangordonhmm16:14
freemangordonwith llvmpipe?16:14
freemangordonon PC?16:14
freemangordondo we have some errors in retrace?16:15
freemangordonWizzup: also, IIUC, we use GLES2 in clutter and OGL in glamor16:15
Wizzupfreemangordon: no, llvmpipe renders fine16:15
Wizzupfreemangordon: but if I render it on my PC it is also wrong with amdgpu16:15
freemangordonso, what is "mesa" then?16:16
Wizzupmy amd radeon mesa driver16:16
freemangordonah16:16
uvoswe can totaly retire the idea that its glamor in any way16:16
freemangordonok16:16
uvosthis was proven in mulitple ways - not least of witch is i just tried the trace on amdgpu with acellMethod=none and dri216:16
uvosand it has the same problem16:16
freemangordonok, but then there seems to be some issue in GL calls16:17
Wizzupin general I think if you look in qapitrace you will see the textures are wrong16:17
Wizzupso whatever flings the texture to the display ultimately is not at fault16:17
freemangordonbut ofc they are wrong16:17
Wizzupyes, mostly saying that's probably not glamor as well16:17
freemangordonah16:17
freemangordonI mean - retrace just displays those textures, like, the content was captured on the device16:18
Wizzupno16:18
freemangordonyes16:18
Wizzupon llvmpipe the same trace looks fine16:18
freemangordonomg16:18
Wizzupyup16:18
freemangordonok, then some gl state is wrong16:18
Wizzuphttps://wizzup.org/dirlist/maemo-leste/lima/16:18
Wizzupif you take maemo-summoner-hildon-desktop-llvmpipe.trace and run it through apitrace16:19
freemangordon*lima* is the bad one, right?16:19
Wizzuphang on16:19
freemangordonI am going to run that on my nvidia16:19
Wizzupyou will see it's wrong even on amdgpu or on lima or etc16:19
uvosits just where the trace was recorded16:19
WizzupBUT16:19
Wizzupif you set LIBGL_ALWAYS_SOFTWARE=1, then it renders fine16:19
uvosif it displays the problem depends on where it plays back16:19
Wizzupso:16:19
freemangordonok, but I want to render it here16:19
freemangordonon PC with NVidia16:19
Wizzupright16:19
Wizzupso:16:19
Wizzupqapitrace /tmp/maemo-summoner-hildon-desktop-llvmpipe.trace16:19
uvosso it renders bad on gallium drivers (except llvmpipe)16:19
Wizzupvs16:20
uvosand on i96516:20
WizzupLIBGL_ALWAYS_SOFTWARE=1 qapitrace /tmp/maemo-summoner-hildon-desktop-llvmpipe.trace16:20
Wizzupwill render differently16:20
freemangordonok, but I could see some issue in GL state16:20
WizzupI haven't tried it with the lima trace since I don't think it matters16:20
Wizzup(it just makes things more complicated)16:20
Wizzupfreemangordon: yes, glEnable(GL_TEXTURE_2D) fails with invalid enum iirc16:21
freemangordonugh:16:21
freemangordonerror: unsupported trace format version 516:21
freemangordonand what is the current texture unit?16:21
freemangordonsorry, the current texture16:21
WizzupI just use apitrace from beowulf repo16:22
freemangordonon my ubuntu?16:22
freemangordonhang on, I have built it16:22
Wizzupactually that glEnable error doesn't occur in the llvmpipe trace I think, only in the lima trace16:23
Wizzupyeah16:23
Wizzup(the llvmpipe trace probably doesn't even use TFP because clutter decides not to use it)16:23
Wizzupfwiw the lima trace renders fine using llvmpipe as well16:24
freemangordonwhich frame to look at?16:24
freemangordonWizzup: also, this is capture of hildon-desktop, correct?16:25
Wizzupfreemangordon: yes16:26
Wizzupfreemangordon: in the lima or llvmpipe trace?16:26
freemangordonlima16:26
Wizzupsec16:26
freemangordonhmm, weird16:27
freemangordonI see nothing wrong with that glEnable(GL_TEXTURE_2D) call16:27
WizzupI think around frame 20 things get a bit weird16:28
Wizzupwhere the framebuffers look different16:28
Wizzupat least in frame 2416:28
WizzupI think in frame 23 the framebuffer is wrong for the first time16:29
Wizzupit looks like in frame 23, after the glDrawArrays, the framebuffer is different16:31
Wizzupso maybe the glVertexAttribPointer stuff messes things up16:32
freemangordonnope16:32
freemangordonit looks fine here16:33
Wizzupyou're not using mesa16:33
Wizzupand that's right before the glEnable(GL_TEXTURE_2D) call16:33
freemangordonno idea what I am using :)16:33
Wizzupwhich fails with16:33
Wizzupwarning: GL_INVALID_OPERATION while reading framebuffer16:33
Wizzupfreemangordon: well, does eglinfo say NVIDIA ?16:34
freemangordonsek16:35
freemangordonsec16:35
freemangordonhttps://pastebin.com/3mrpsCQs16:37
freemangordonWizzup: ^^^16:37
Wizzupyeah that is proprietary and binary driver16:37
Wizzupnot mesa16:37
freemangordonbut, it works :)16:38
Wizzupyes, which points towards differences in gl implementation, i.e. maybe mesa bug16:38
freemangordonhmm, wait16:38
Wizzupbtw, when you wrote 'it works', I assume you also dumped all images16:38
freemangordonhow to do that?16:39
freemangordonI am using UI16:39
freemangordonWizzup: we should not have white stripe between black stripes, right?16:39
Wizzupright16:39
freemangordonok16:39
Wizzupfreemangordon: apitrace dump-images tracefile fileprefix16:39
Wizzuperr16:39
Wizzupfreemangordon: apitrace dump-images tracefile -o fileprefix16:40
Wizzupfreemangordon: also see cmd.txt file if you want only one image16:40
Wizzuphttps://wizzup.org/dirlist/maemo-leste/lima/dump-images/cmd.txt16:40
Wizzupso in this case16:40
Wizzupapitrace dump-images maemo-summoner-hildon-desktop-lima.trace -o lima-trace-amdgpu-redraw --calls=235716:40
Wizzupyou can change lima-trace-amdgpu-redraw to lima-trace-nvidia-redraw16:40
freemangordonok, it is broken here as well16:40
Wizzupok16:40
Wizzupthis doesn't /have/ to mean it is not a mesa bug16:41
freemangordonin frame 3016:41
Wizzupas in, it could be the case that the lima trace has other bugs16:41
Wizzupor rather, the bugs were somehow trace induced I would say16:41
Wizzupthe cmd.txt has the other one to run the llvmpipe one as well16:42
Wizzupapitrace dump-images maemo-summoner-hildon-desktop-llvmpipe.trace -o llvmpipe-trace-amdgpu-redraw --calls=354216:42
Wizzupwhich should be: https://wizzup.org/dirlist/maemo-leste/lima/dump-images/llvmpipe-trace-llvmpipe-redraw0000003542.png16:42
Wizzupmy amd gpu with mesa makes it: https://wizzup.org/dirlist/maemo-leste/lima/dump-images/llvmpipe-trace-amdgpu-redraw0000003542.png16:43
freemangordonhmm16:43
Wizzupmaybe check that as well just to be sure16:43
Wizzup(i.e. what does nvidia make of that)16:43
freemangordonthe same16:44
Wizzupthe same - as whatr16:45
freemangordonyep, exactly the same16:45
freemangordonlike amd redraw16:45
Wizzupok16:45
Wizzupfwiw I think uvos say something else with his mesa16:45
Wizzups/say/saw/16:45
WizzupI am going for a quick walk and maybe try to make sense of this later today16:46
freemangordonI am going on a party, laters (or rather tomorrow) :)16:47
Wizzupyep, enjoy16:48
freemangordonWizzup: wait, wait16:49
Wizzup?16:50
freemangordonwhat we see here is actually the texture imported by glEGLImageTargetTexture2DOES16:51
Wizzupwhat is 'here'?16:51
freemangordonin apr retrace16:51
freemangordon*apiretrace16:51
Wizzupso in qapitrace, or in dump images?16:51
freemangordonthis *is* what has been recorded on the device16:51
freemangordonboth16:51
Wizzupyes, but they render fine in llvmpipe still16:52
Wizzupand you can see the frame buffer gets wrong in the non-llvmpipe trace16:52
Wizzupqapitrace has a thing for the separate textures and framebuffers16:52
freemangordonsure16:52
freemangordon"surfaces"16:53
Wizzuphttps://wizzup.org/check.png for example the lima trace already looks different here16:53
Wizzuplater on the framebuffers also become different16:53
Wizzupprobably because a different texture is drawn16:54
Wizzupnvm my screenshot has different calls selected16:54
Wizzupanyway you get the diea16:54
freemangordonthe point is - texture content gets recorded in the trace16:55
Wizzupupdated the screenshot16:55
Wizzupfreemangordon: then how come they are different in the same trace and different drivers?16:55
Wizzupotherwise I am not arguing with you16:55
Wizzupsee https://wizzup.org/check.png (refresh)16:55
freemangordonyes, refreshed16:55
freemangordonso, framebuffers differ16:55
Wizzupyes, this is where they start to differ16:55
freemangordonand that could be a result of bad GL calls16:56
freemangordonbut, textures cannot differ16:56
Wizzupyes, but the llvmpipe results ends up being correct still16:56
Wizzupok16:56
Wizzupsure16:56
freemangordonbecause their contents comes from the trace16:56
Wizzupthat's why I suggested to use the llvmpipe trace :)16:56
freemangordonah16:56
freemangordonok16:56
freemangordon:)16:56
Wizzupbut it has the same problems16:56
freemangordonhmm, something 64bit related?16:57
Wizzupin clutter you mean?16:57
freemangordonit is possible that clutter has issues calculating vertex buffer contents16:57
freemangordonyes, in clutter16:57
Wizzupcould be, but aren't our VMs 64 bit?16:58
freemangordonor uniforms16:58
freemangordonyes, they are16:58
freemangordonbut FP has different representation in intel and ARM16:58
Wizzupit is possible, but I'd like to first understand where the problem comes from16:59
freemangordonso on intel we might not have issues simple because of the way FP values are represented in memory16:59
Wizzupagain, llvmpipe does not show problems16:59
freemangordonI understand taht16:59
Wizzupdoesn't that use the same fp calc?16:59
Wizzupand also disabling TFP and forcing fallback has the same problems16:59
Wizzupbut I suppose vbo's are still in play somehow17:00
Wizzup<--- not expert on gl17:00
freemangordoncould you compare uniforms betwee llvmpipe and amd?17:00
Wizzupcompare at which step?17:00
freemangordonglUniformMatrix...17:01
freemangordonhmm, why vertex buffers data is not avalable :(17:02
Wizzupthey look the same to be17:03
Wizzupto me*17:03
freemangordonWizzup: hmm, in llvmpipe capture there are no (visible)textures17:05
Wizzupfreemangordon: there is no tfp17:06
Wizzupit's x11 fallback17:06
freemangordonah, right :)17:06
* Wizzup actually afk for ~15 mins now17:08
freemangordonok17:08
freemangordonfor me it is broken with  LIBGL_ALWAYS_SOFTWARE=1 too17:15
freemangordonlima trace that is17:15
uvosyou use nvidia gl17:15
uvosthat dosen suport that envvar no?17:15
freemangordonno idea17:16
freemangordonlemme check17:16
uvosit dosent17:16
uvosits implemendted by mesa17:16
freemangordonyeah17:16
freemangordonok, my gut feeling tells me we have some issues in clutter because of 64 bits17:17
freemangordonbut, will continue tomorrow.17:18
freemangordonnight!17:18
Wizzupso the gl invalid enum could be because of this: https://community.khronos.org/t/getting-gl-invalid-enum-when-calling-glenable-gl-texture-2d/72631/217:44
Wizzuplooks like gles doesn't support it (obviously I guess)17:46
uvosgles2 dosent have ff17:47
uvosso probubly not17:47
Wizzupyeah17:48
Wizzupbtw: https://github.com/apitrace/apitrace/issues/180#issuecomment-2731912217:56
Wizzupdoesn't look like we do that though17:56
Wizzupfreemangordon: btw it doesn't look like the debian patches are applied at all17:58
Wizzupof clutter17:58
Wizzuplooks like we have them in git, to nvm17:59
lelDastan-glitch synchronize a pull request: https://github.com/maemo-leste/liblocation/pull/1 (More readable code + factors)19:45
rafael2khttps://gitlab.com/debian-pm/devices/sunxi-mali19:50
lelparazyd closed a pull request: https://github.com/maemo-leste/liblocation/pull/1 (More readable code + factors)19:54
Wizzupparazyd: maybe the code can mention why the measuring math was changed, and to what19:57
WizzupI see it in the PR but not in the code19:57
parazyd*shrug*19:59
parazydI don't want to scare off people contributing by being super pedantic19:59
Wizzuphe mentions a better algorithm but then we don't actually use it19:59
Wizzupparazyd: I committed the comments to liblocation20:03
Wizzupif this breaks it would be nice to know where it came from, so I added the guys remark20:04
Wizzupas in I don't think we test this code at all yet (distance from p1 to p2) so we probably don't know if it works even20:04
parazydok, thanks20:05
parazydIt's a textbook algorithm20:05
Wizzupright but we're swapping one textbook one out for another20:07
WizzupI don't know if there's a reason one is more accurate for small distances than others, or why nokia went for one that's more accurate for longer distances20:07
Wizzupas in why not go for the 'king' algorithm20:08
parazydThis new one is faster20:11
parazydAnd my algorithm was also from a textbook, not from the binary.20:11
Wizzupoh20:12
Wizzupuvos: I added nvidia renders here: https://wizzup.org/dirlist/maemo-leste/lima/dump-images/20:19
rafael2kI forked20:21
rafael2kpine64-kernel20:21
rafael2kwill go for mobian 5.15.x with pp patches, which is pretty decent20:21
Wizzupsounds great20:21
Wizzupplease add the battery patch20:21
rafael2kyeap, that will be the only "extra" patch20:22
rafael2kI will just take some days, as testing each different setup takes some time to compile natively20:23
rafael2kbut I have no rush20:23
rafael2k:P20:23
Wizzuphmm ok20:23
Wizzupwhy compile natively?20:23
Wizzupcross compiling the kernel is probably the easiest cross compile ever imho20:24
rafael2kwhy not?20:24
Wizzupbecause your laptop can probably do it in ~3 mins :P20:24
rafael2kif the pp does not make it or take way too much, I'll cross20:24
Wizzup*shrug* up to you :P20:25
rafael2kI even connected it to a powerfull wall adapter, hopefully it will not turn off... eheheheh20:26
rafael2kbut after I managed to compile mozilla with -j1, I think anything will be possible20:26
rafael2kthe PR should go to beowulf-devel right (the debian dir)?20:28
Wizzupright, well, also the actual code needs to go the repo and also a tag20:28
Wizzupso probably you don't want to do it in a pr and rather tell me or parazyd 'pull this code in'20:30
rafael2kright... importing sunxi64-linux to github... it is taking some time20:31
Wizzupyes, usually the right way to do it is just merge it stuff into the existing tree20:31
Wizzupsince 99.99999% of the tree is shared20:31
rafael2kok, but mobian keeps the debian/ dir already inside the repo... I will kick it out (and may be borrow some stuff)20:32
rafael2khum, I could just have forked torvals/linux... just realized mobian git basically is the linux kernel + debian dir20:33
rafael2k:/20:33
Wizzupit doesn't really matter, you can keep the debian dir in there20:33
Wizzupyes20:33
rafael2kok20:33
parazydYou can't push a whole kernel tree at once to github btw20:34
parazydhttps://parazyd.org/pub/dev/random/push-in-increments.sh20:35
Wizzupyou can just have a linux repo with many remotes20:35
WizzupI do that for n9xx-linux, droid4-linux, pine64-linux, etc20:35
parazydYeah I mean pushing to an empty gh repo20:35
Wizzupgit is clever enough to sort everything else out20:35
rafael2khow I miss subversion...20:37
rafael2k:P20:37
Wizzuplet me be blunt20:38
Wizzupyou only miss it because you don't understand the power of git yet20:38
Wizzup<--- coming from someone who used to like svn20:38
rafael2keheheheh20:38
rafael2kso good the r1234... knew by heart the commit numbers20:40
rafael2kI understand the power... I just don't need it20:41
rafael2ktarballs, patch and diff are good20:41
rafael2kanyway, I use git everywhere...20:42
rafael2klemme focus here on this kernel not to forget upower lines20:42
Wizzup:)20:42
rafael2kyay, checking the patches for the 5.15, we'll have already the pinephone keyboard support, when it hit the streets21:09
rafael2kthese ubuntu-touch guys are really annoyng.. a patch to config just to remove sysrq support... I like it so much21:10
uvoswe do that too21:11
rafael2k:(21:11
uvosits because uart devices21:11
rafael2kany reason?21:11
uvoscan be noisy so sometimes they broadcast sysrq randomly21:11
rafael2kright, did not know21:11
uvos mapphones have this problem for instance they would just spontainously reboot21:12
uvosbecause of sysreq being pressed by pluging in a charger :P21:12
rafael2kso cool to alt+sysrq+O and the computer just instantly shuts down21:12
rafael2kshit21:12
rafael2kright, sysrq stays N then21:12
uvoswell we dont disable sysrq in kernel21:13
uvosbut we do so early in the boot proccess via init21:13
rafael2kthis is more elegant...21:13
uvosso that it still works if you need it to debug the phone21:13
rafael2kI'll not touch the mobian config to start, as it is working fine, just add the patch we need to make battery leve appear, and we should be fine21:16
rafael2kcrypto modules are there already, all good21:18
Wizzup:)21:19
rafael2khttps://github.com/rafael2k/pine64-kernel/tree/maemo/beowulf-devel22:02
Wizzupok so now we need a branch with the kernel code and a tag that points to it22:04
Wizzupin this case the tag needs to be: https://github.com/rafael2k/pine64-kernel/blob/maemo/beowulf-devel/debian/gbp.conf22:04
Wizzupmaemo-kernel-5.1522:04
rafael2kok22:07
rafael2kshould I change anything?22:08
rafael2kah ok, the tag in the git...22:08
rafael2kshit, I put the kernel in another repo22:09
rafael2kit will be here (still creating): https://github.com/rafael2k/sunxi64-linux22:10
rafael2kgit is powerfull, I will find a way22:11
Wizzupwhat branch is the kernel at?22:15
WizzupI can try to pull it in22:15
Wizzupyeah ok it's still empty :(22:15
Wizzupyou really ought to just add it to the pine64-kernel repo22:16
Wizzuprafael2k: did you know git remotes can just be filesystems?22:16
Wizzuprafael2k: rather, paths on the filesystem22:16
Wizzuprafael2k: so from pine64-kernel you can probably do something like22:17
Wizzupgit add remote sunxi64 /path/to/sunxi-kernel/.git (or so)22:18
Wizzupand then git checkout -t sunxi64/kernel-branch-yeah from pine64-kernel22:18
Wizzupand then just git push that22:18
Wizzup(this is untested but I think it can work)22:18
rafael2ktks!22:22
rafael2kif kernel works fine and debian package build finish successfully, I'll shout for help on how to use git22:26
rafael2k; )22:26
Wizzupk22:27
Wizzupmeanwhile new mesa is hitting beowulf-devel finally22:27
Wizzupsicelo: now I think you should be able to apt-get dist-upgrade (well, in a few minutes)22:28

Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!