| rafael2k | changes really minimal... I hope it boots without initrd: https://github.com/rafael2k/pine64-kernel/blob/maemo/beowulf-devel/debian/patches/maemo/0215-maemo-config.patch | 00:00 |
|---|---|---|
| rafael2k | I around 6 hours I tell the result | 00:01 |
| rafael2k | :P | 00:01 |
| rafael2k | btw, can anyone remind me how to disable the virtual keyboard? | 00:03 |
| Wizzup | rafael2k: in settings | 00:20 |
| Wizzup | rafael2k: great, thanks for checking @ patch, let's see indeed :) | 00:20 |
| Wizzup | rafael2k: I agree we don't need to remove modules that are not needed | 00:21 |
| rafael2k | : )) | 01:08 |
| * Wizzup zz :) | 01:17 | |
| rafael2k | compilation still going on, set cpu governor to powersave, all good | 05:54 |
| freemangordon | sicelo: not really, android here starts charging when booted with charger connected | 07:40 |
| freemangordon | tmlind: this https://github.com/maemo-leste/droid4-linux/commit/f56836db3ec4210c5cfaf40fa721a6e21cd7730e | 07:41 |
| freemangordon | and this https://github.com/maemo-leste/droid4-linux/commit/067976f0afd4a65bf32a3f450ee42f508a1b0612 | 07:42 |
| sicelo | rafael2k: ov5640 must be built in? | 07:42 |
| freemangordon | tmlind: though, better wait before including those, I plan to sent patches to Tomi and most-probably will reword commit descriptions | 07:44 |
| freemangordon | *send | 07:45 |
| tmlind | freemangordon: ok i'll add those tonight so then we should have a complete dev branch | 07:57 |
| tmlind | bbl tonight | 08:00 |
| rafael2k | [137029.457550] udevd[19047]: failed to execute '/usr/sbin/iw' '/usr/sbin/iw wlan0 set power_save on': No such file or directory | 08:08 |
| rafael2k | sicelo: it does not matter, it will be loaded in memory anyway, but it could be a module, yes | 08:09 |
| rafael2k | just finish kernel compilation now, if it works, we could just flip ov5640 to M for the repo package | 08:11 |
| rafael2k | iw is in /sbin/iw, but udevd looks for it in /usr/sbin | 08:12 |
| * dsc_ shoots at dbus | 08:12 | |
| rafael2k | unified usr seems a good option to solve this | 08:13 |
| rafael2k | I can just delete from the patch both cameras as built-in (GC2145 is also built-in) - will do it after I make sure kernel works | 08:18 |
| rafael2k | yay, package created | 08:18 |
| rafael2k | : ) | 08:18 |
| rafael2k | can anyone point me where to get boot.txt currently used for maemo pinephone images, so I can make sure kernel works with default configuration? | 08:27 |
| rafael2k | http://www.abradig.org.br/pinephone/kernel-5.15.13/ | 08:29 |
| rafael2k | kernel from: https://gitlab.com/mobian1/devices/sunxi64-linux/ branch mobian-5.15 | 08:30 |
| freemangordon | tmlind: could you have a look at https://pastebin.com/PYnDYxPv ? Please advice if you think something shall be added/removed/etc to the commit message. This is the commit that most-probably Tomi will NACK, so I want to format the commit message in the best possible way. | 08:50 |
| freemangordon | tmlind: v2 https://pastebin.com/0pEweJKJ | 08:55 |
| rafael2k | also fetched from upstream the kernel we will use: https://github.com/rafael2k/sunxi64-linux | 08:59 |
| rafael2k | yay | 09:31 |
| rafael2k | kernel boots fine | 09:31 |
| rafael2k | without initrd | 09:31 |
| rafael2k | ready to ship! | 09:31 |
| rafael2k | : ) | 09:31 |
| freemangordon | tmlind: v3 https://pastebin.com/JE2CUGet (added tested-on) | 09:54 |
| tmlind | freemangordon: will look more tonight, but make the why the patch is needed part as clear as posible :) | 09:58 |
| freemangordon | I tried to do so, not sure I was able to, that's why I need you help there :) | 09:59 |
| tmlind | without really understanding what's going on.. the subject line for your fix may no longer be in sync with the description? | 10:00 |
| freemangordon | it is, to the extend I understand it. If you wish, lets discuss that when you have time to spend on it | 10:04 |
| freemangordon | keep in mind this is very important patch, without that all this is basically useless for 'production' type of use | 10:04 |
| freemangordon | so I would appreciate all the help I can get to push it upstream | 10:05 |
| tmlind | yeah ok i'll look tonight | 10:19 |
| lel | rafael2k synchronize a pull request: https://github.com/maemo-leste/leste-config/pull/27 (fix voice calls in pinephone) | 10:24 |
| Wizzup | rafael2k: great, ty | 10:47 |
| rafael2k | lel: hey, we'll need a full reworking in there... lets get the kernel first | 10:49 |
| rafael2k | lel: iw patch is wrong in udev rule too | 10:50 |
| Wizzup | rafael2k: lel is a bot | 10:50 |
| Wizzup | rafael2k: udev should honour $PATH | 10:50 |
| rafael2k | Wizzup: lemme remove the camera drivers to built-in, as they need some firmware, better keep as module | 10:50 |
| rafael2k | eheheheh | 10:50 |
| rafael2k | SUBSYSTEM=="power_supply", ENV{POWER_SUPPLY_TYPE}=="USB", ENV{POWER_SUPPLY_ONLINE}=="1", RUN+="/usr/sbin/iw wlan0 set power_save off" | 10:50 |
| rafael2k | no PATH here... https://github.com/maemo-leste/leste-config/blob/master/leste-config-pinephone/lib/udev/rules.d/70-wifi-pm.rules.leste | 10:51 |
| rafael2k | lel: good talking to you lel! | 10:51 |
| rafael2k | btw, we need new ucm stuff for 5.15.13 | 10:53 |
| rafael2k | using alsa directly is all good, so drivers are fine, but config needs some changes | 10:53 |
| rafael2k | we need firmware for front camera and bluetooth in pinephone, which is not packaged yet | 10:54 |
| rafael2k | btw, which apps do you use in Maemo for navigator (modRana?) and camera? | 10:56 |
| rafael2k | also irc, which one do you recommend? (I'm stuck with BitchX for decades... but need to move ahead) | 10:56 |
| lel | rafael2k closed a pull request: https://github.com/maemo-leste/leste-config/pull/27 (fix voice calls in pinephone) | 10:56 |
| Wizzup | rafael2k: on irc, I use irssi on my server and then ssh from maemo | 11:00 |
| Wizzup | but I am working on supporting it in conversations | 11:00 |
| Wizzup | rafael2k: let me get on the kernel stuff after I am awake :) | 11:01 |
| rafael2k | ok | 11:02 |
| rafael2k | just a sec | 11:02 |
| rafael2k | let me revert the patch of the camera drivers to M | 11:02 |
| rafael2k | I hope not to break nothing | 11:02 |
| rafael2k | Wizzup: conversations! true! | 11:03 |
| Wizzup | rafael2k: sure camera is not used for booting, should be ok | 11:03 |
| rafael2k | Wizzup: and it needs firmware too, better keep as M | 11:04 |
| rafael2k | ok, done | 11:06 |
| Wizzup | yeah | 11:06 |
| rafael2k | want a PR? | 11:06 |
| Wizzup | if you have a branch with the changes all ready that is fine teoo | 11:06 |
| Wizzup | s/teoo/too/ | 11:06 |
| Wizzup | I am just merge it in without a PR | 11:06 |
| rafael2k | you decide, it is just a click in a button | 11:06 |
| rafael2k | :P | 11:06 |
| Wizzup | yeah just do it | 11:06 |
| Wizzup | (PR) | 11:06 |
| rafael2k | ok | 11:06 |
| lel | rafael2k opened a pull request: https://github.com/maemo-leste/pine64-kernel/pull/1 (Maemo/beowulf devel) | 11:07 |
| Wizzup | do you have a pr for the ucm btw? | 11:12 |
| Wizzup | rafael2k: btw why did you remove debian/patches/mobian/0213-builddeb-don-t-build-linux-libc-dev-package.patch ? | 11:13 |
| Wizzup | oh wait | 11:13 |
| Wizzup | I did that | 11:13 |
| Wizzup | from series at least | 11:13 |
| Wizzup | rafael2k: what head of mobian 5.15 do you want tagged | 11:15 |
| lel | rafael2k opened a pull request: https://github.com/maemo-leste/leste-config/pull/29 (set correct path to iw) | 11:16 |
| lel | MerlijnWajer closed a pull request: https://github.com/maemo-leste/pine64-kernel/pull/1 (Maemo/beowulf devel) | 11:16 |
| rafael2k | Wizzup: I dunno | 11:17 |
| rafael2k | 5.15.13 | 11:17 |
| rafael2k | the kernel is https://gitlab.com/mobian1/devices/sunxi64-linux or here https://github.com/rafael2k/sunxi64-linux/ | 11:18 |
| Wizzup | I mean you wrote you rebased | 11:18 |
| Wizzup | so what commit is HEAD for you | 11:18 |
| rafael2k | the latest of this I mentioned ^ | 11:18 |
| rafael2k | yelp me with this please | 11:19 |
| rafael2k | : ) | 11:19 |
| Wizzup | https://gitlab.com/mobian1/devices/sunxi64-linux/-/commits/mobian-5.15/ this? | 11:19 |
| rafael2k | yes! | 11:20 |
| rafael2k | Wizzup: about debian/patches/mobian/0213-builddeb-don-t-build-linux-libc-dev-package.patch, yes, you did that, and I think it was on purpose, as we have the maemo-quirks stuff on top of the Makefile, but if you want that, it would be easy to rebase | 11:21 |
| Wizzup | hm? no it's fine | 11:22 |
| Wizzup | ok build is running | 11:22 |
| rafael2k | it is fine indeed | 11:22 |
| Wizzup | see https://github.com/maemo-leste/pine64-kernel/tree/mobian-5.15 and https://github.com/maemo-leste/pine64-kernel/tree/maemo/beowulf-devel | 11:23 |
| rafael2k | seems all good... I hope I did the job right in git mobian-5.15. | 11:25 |
| Wizzup | we'll see :) | 11:26 |
| rafael2k | fingers crossed | 11:28 |
| Wizzup | freemangordon: shall I cherry pick the tearing patch into our 5.15 | 11:28 |
| Wizzup | we could also try to go to 5.16 soon, but I am a bit inclined to get 5.15 to stable first | 11:29 |
| freemangordon | Wizzup: lets freeze for a while | 11:29 |
| Wizzup | ok | 11:29 |
| freemangordon | :nod: | 11:29 |
| Wizzup | but do we pick the tearing patch? | 11:29 |
| freemangordon | no | 11:29 |
| Wizzup | ok | 11:29 |
| freemangordon | it is not critical | 11:29 |
| Wizzup | I also want to work on a news post some, I think today | 11:29 |
| Wizzup | going to be a lot | 11:30 |
| freemangordon | also, I think we shall focus on fixing the pile of issues we currently gave in -devel, push to -stable and then start working on new stuff | 11:30 |
| Wizzup | as opposed to? | 11:30 |
| freemangordon | pushing new things to -devel | 11:31 |
| Wizzup | I mean I agree, just not sure to what issues it translates for you exactly | 11:31 |
| freemangordon | charging on d4, vtklock | 11:31 |
| freemangordon | both are terribly broken in -devel | 11:31 |
| Wizzup | I don't know if they are working on stable, I had bad experiences on stable and it is ok for me now on -devel | 11:31 |
| freemangordon | also, issues we see on n900 | 11:31 |
| Wizzup | maybe we need a list | 11:31 |
| freemangordon | well, not sure about stable, but both were working pretty much ok for me and got broken ~2 weks ago | 11:32 |
| freemangordon | *weeks | 11:32 |
| Wizzup | so the recent patch didn't help? | 11:32 |
| freemangordon | helped a little bit | 11:33 |
| freemangordon | like, device charges | 11:33 |
| freemangordon | but there are no notifications | 11:33 |
| Wizzup | imho my main non-telepathy prio is figuring out why the pinephone vkb is broken because I am hoping we can get enunez' help still | 11:33 |
| Wizzup | hmm I see @ notifications | 11:33 |
| freemangordon | this is kernel issue for sure | 11:33 |
| freemangordon | (PP) | 11:34 |
| Wizzup | the vkb stuff? | 11:34 |
| freemangordon | because it works ok on -stable | 11:34 |
| freemangordon | yes | 11:34 |
| Wizzup | oh, ok, let's get new kernel first then | 11:34 |
| freemangordon | mhm | 11:34 |
| freemangordon | so, I think the plan shall be - fix those issues, push to stable, start implementing new things | 11:36 |
| freemangordon | yeah, d4 with charger connected on boot does not charge | 11:37 |
| freemangordon | this was working for sure | 11:37 |
| uvos | works fine here | 11:37 |
| uvos | wierd | 11:37 |
| freemangordon | uvos: did you have a look at mce log I pasted ^^^ | 11:37 |
| uvos | i did but its useless without knowing when the states changed relative to tklock states | 11:38 |
| uvos | so a tklock log with times would be required | 11:38 |
| uvos | but im pretty sure i know what the issue is anyhow | 11:38 |
| uvos | just cant repoduce this problem eihter | 11:38 |
| uvos | (without pressing power to cause race on purpose) | 11:38 |
| uvos | also no way it worked a couple of weeks ago | 11:38 |
| freemangordon | uvos: but why I see 2 power buttin presses in that log? | 11:38 |
| freemangordon | *button | 11:38 |
| uvos | mce has had no changes in a long time really | 11:39 |
| freemangordon | I pressed it only once | 11:39 |
| uvos | oh ok | 11:39 |
| uvos | hmm | 11:39 |
| freemangordon | and yes, I can assure you that was working fine | 11:39 |
| uvos | well a change in mce dident cause this then | 11:40 |
| uvos | your not getting 2 events in evtest right? | 11:40 |
| freemangordon | no idea | 11:40 |
| freemangordon | I can test | 11:40 |
| uvos | i cant find the log | 11:40 |
| uvos | something bad happend with irc.txt | 11:41 |
| freemangordon | sec | 11:41 |
| uvos | it has corruption | 11:41 |
| freemangordon | https://pastebin.com/ywFJiQbH | 11:41 |
| freemangordon | oh | 11:43 |
| uvos | hmm? | 11:43 |
| freemangordon | uvos: that is double-press timeout? | 11:43 |
| freemangordon | *what is | 11:43 |
| uvos | dunno what is default | 11:44 |
| uvos | PowerKeyDoubleDelay=1000 | 11:44 |
| freemangordon | yeah, this is the bug | 11:45 |
| uvos | explain? | 11:45 |
| freemangordon | lock the screen, press power button, while vtklock is displayed, press power button again | 11:45 |
| freemangordon | swipe to unlock | 11:46 |
| uvos | ok | 11:46 |
| uvos | dident see anything | 11:46 |
| uvos | do i have to do this fast? | 11:46 |
| freemangordon | or actually double-press to show vtklock | 11:46 |
| freemangordon | yes | 11:47 |
| freemangordon | seems second press got queued somewhere | 11:47 |
| uvos | ah yeah | 11:47 |
| uvos | you can douple press | 11:47 |
| uvos | and then mce thinks its double press to lock | 11:47 |
| uvos | sometimes | 11:47 |
| freemangordon | but this should get reset on vtklock being shown | 11:47 |
| uvos | i gues your device might have a bouncy/dirty power button | 11:47 |
| uvos | makeing this happen more often | 11:48 |
| freemangordon | yeah, could be | 11:48 |
| uvos | ok | 11:48 |
| freemangordon | but still, a bug in mce to me | 11:48 |
| uvos | ok | 11:48 |
| uvos | i gues | 11:48 |
| uvos | at least this can be imporved | 11:48 |
| uvos | ill do it | 11:48 |
| freemangordon | thanks | 11:48 |
| freemangordon | also, sometimes single-press does not get registered | 11:49 |
| freemangordon | but evtest shows it | 11:49 |
| uvos | dose mce ragister anything wiht the power button | 11:49 |
| uvos | in the log | 11:49 |
| freemangordon | also, double-press wait for a second or so to lock the device | 11:50 |
| uvos | in this case | 11:50 |
| freemangordon | lemme check | 11:50 |
| uvos | do think it wait | 11:50 |
| uvos | s | 11:50 |
| uvos | really | 11:50 |
| uvos | its just xinput and dpms calls to x take pretty long | 11:50 |
| freemangordon | a second? | 11:50 |
| uvos | and mce executes these sync | 11:50 |
| uvos | yeah dpms takes forever | 11:50 |
| uvos | and only returns after the display is off | 11:50 |
| freemangordon | hmm, we shall fix that somehow | 11:51 |
| freemangordon | I mean - a second to turn display off :( | 11:51 |
| uvos | its also tklock too | 11:51 |
| uvos | so mce waits on xinput first, then tklock, then dpms | 11:51 |
| uvos | (depedns on what order you load the modules) | 11:52 |
| freemangordon | tklock should be fast | 11:52 |
| uvos | vtklock is slow | 11:52 |
| uvos | no idea how fast tklock is | 11:52 |
| freemangordon | but yeah, I guess we shall measure the times | 11:52 |
| freemangordon | and try to optimize | 11:52 |
| freemangordon | not high prio though, lets make it work corectly first :) | 11:52 |
| uvos | vtklock is quite slow tho | 11:52 |
| uvos | if you load lock-generic instead of tklokc | 11:52 |
| uvos | mce is mutch faster | 11:52 |
| uvos | anyhow yeah | 11:53 |
| freemangordon | yeah, I plan to improve vtklock someday | 11:53 |
| freemangordon | as it also has those nasty rendering artefacts too | 11:53 |
| uvos | hmm what artifacts? | 11:53 |
| uvos | i dont see any | 11:53 |
| uvos | other than it breaking in portrait | 11:54 |
| uvos | (not really a artifact as sutch) | 11:54 |
| freemangordon | slider is displayed incorrectly for a split second | 11:54 |
| Wizzup | yeah (displayed incorrectly) and portrait would be good to have | 11:54 |
| freemangordon | uvos: can't repro missed single-press now | 11:56 |
| freemangordon | I restarted mce, so... | 11:56 |
| freemangordon | uvos: also, I think mce verbose log must display time | 11:57 |
| freemangordon | it is with limited usefulness otherwise | 11:57 |
| uvos | well it logs to syslog | 11:57 |
| uvos | so that adds time | 11:58 |
| uvos | but sure | 11:58 |
| freemangordon | does it? | 11:58 |
| uvos | theres an option for it yeah | 11:58 |
| freemangordon | ah, yeah | 11:58 |
| freemangordon | ok, but when it logs to the console, there are no times | 11:58 |
| freemangordon | but yeah, not a biggie | 11:58 |
| rafael2k | reading your messages - is vkb in pp broken? did not know that. I'm kind of using it sometimes... | 12:06 |
| uvos | renders wrong | 12:06 |
| rafael2k | how it renders wrong? | 12:08 |
| rafael2k | I renders fine. | 12:09 |
| rafael2k | *It | 12:10 |
| rafael2k | what renders wrong is the lock screen in portrait mode. | 12:11 |
| rafael2k | What needs imho in pp is: kernel update, add some missing firmware (camera / bluetooth), rework the alsa/ucm/pulseaudio config to match new kernel, new ofono, fix graphics rendering issues (noaccell is working fine thou) | 12:15 |
| rafael2k | and voila, I would call it stable. of course the only hard issue is the fix for the rendering issues... | 12:15 |
| Wizzup | rafael2k: yeah so I can do the ofono stuff | 12:16 |
| Wizzup | rafael2k: and the kernel stuff is happening now | 12:16 |
| Wizzup | missing firmware (cam) - if you make a pr I can look at it, for ucm, I suppose we can get a ucm from mobian? | 12:16 |
| Wizzup | wrt graphics rendering, someone was helping us with it, but he ran into a vkb problem | 12:16 |
| Wizzup | which seemed to be kernel problem per fmg, so hopefully your kernel helps | 12:16 |
| rafael2k | Wizzup: I'll look the audio setup in mobian, yes | 12:17 |
| Wizzup | great work :) | 12:17 |
| Wizzup | let's see how the kernel goes when it's done | 12:17 |
| rafael2k | concerning the missing firmware, that is easy thing, until next weekend I can sort this out | 12:18 |
| Wizzup | we might have a package for the firmware already, not sure, maybe parazyd knows? | 12:18 |
| Wizzup | rafael2k: oh btw, did you get the keyboard already? | 12:18 |
| Wizzup | rafael2k: iirc we needed to pull in some extra commits for the keyboard to work | 12:19 |
| rafael2k | I just see some messages in dmesg about missing firmware for one of the cameras and bluetooth | 12:19 |
| rafael2k | Wizzup: keyboard support is enabled in the new kernel | 12:19 |
| rafael2k | Wizzup: Also PPP support is in place | 12:19 |
| rafael2k | Wizzup: as soon as the PP keyboard arrives, we'll have support | 12:20 |
| Wizzup | rafael2k: great, someone who was here the other day already had one but said our (stable) kernel didn't work yet | 12:21 |
| Wizzup | rafael2k: through kernel yeah, not userspace? | 12:21 |
| rafael2k | Wizzup: we did not copy the new PPP dtb... lets leave this for the next kernel build | 12:21 |
| Wizzup | yeah | 12:22 |
| rafael2k | I think we also need a updated u-boot, then it should boot fine. | 12:22 |
| Wizzup | for ppp you mean | 12:23 |
| rafael2k | most of the peripherals are the same in ppp, apart of the SoC itself, so support should be pretty simple | 12:23 |
| rafael2k | yes, for ppp | 12:23 |
| Wizzup | wonder if its power management will be any better | 12:23 |
| rafael2k | I would not hold my breath... | 12:24 |
| rafael2k | the SoC sucks even more power... | 12:24 |
| rafael2k | pp keyboard is a must-have to use it a whole day without a power bank or a socket... | 12:25 |
| Wizzup | ow | 12:25 |
| * Wizzup is happy his droid4 lasts 2-3 days | 12:25 | |
| rafael2k | at least is keeps my pocket warm | 12:25 |
| Wizzup | lol | 12:26 |
| rafael2k | :P | 12:26 |
| uvos | freemangordon: yeah so experiamenting with mce a bit it looks like the problem is how double press is registered too | 12:33 |
| uvos | freemangordon: so mce times from when it reads the event | 12:34 |
| uvos | freemangordon: instead of the kernels reporting time of the event | 12:34 |
| uvos | freemangordon: so thats pretty terrible | 12:34 |
| uvos | since if mce gets stalled for any reason | 12:34 |
| uvos | any 2 presses of the power button will be a double press | 12:35 |
| uvos | since mce will read them at the same time when it unstalles | 12:35 |
| freemangordon | well, I don;t quite agree, as when you single-press, mce reacts to that and shows tklock | 12:58 |
| freemangordon | if there was a second press after that, it should not be treated as a double-press | 12:59 |
| freemangordon | becasue single-press was already registered and acted upon | 12:59 |
| uvos | freemangordon: right except the double press timeout was allready registerd | 12:59 |
| uvos | freemangordon: then mce stalls | 13:00 |
| freemangordon | I guess you mean some implementation detail | 13:00 |
| uvos | the implementation is just terrible | 13:00 |
| freemangordon | so, you can;t cancel that timeout? | 13:00 |
| uvos | no beacuse mce is stalled | 13:00 |
| uvos | by the time its unstalled the timeout is over | 13:00 |
| freemangordon | or, you callback function you can't check what is the current state? | 13:00 |
| freemangordon | s/you/in | 13:01 |
| freemangordon | that should be doable, no? | 13:01 |
| uvos | thats not the real solution | 13:01 |
| uvos | theres lots of issues here | 13:01 |
| uvos | the real problem is that powerkey assumes it processes events in real time, so it assumes that the delay between 2 presses and between press and release is the time between when it processes these events | 13:02 |
| uvos | and also that mce state when the keys where pressed is the state _now_ when it processes them | 13:02 |
| uvos | the solution is to rewirte it to instead look only at the time value in the event struct | 13:02 |
| uvos | to make sutch descissions | 13:02 |
| freemangordon | sorry, have to attend work mtg, ttyl | 13:03 |
| Wizzup | rafael2k: kernel build completed | 16:16 |
| Wizzup | freemangordon: got this: https://dpaste.com/57JRLGQP9 | 18:05 |
| Wizzup | freemangordon: with accompanying https://dpaste.com/AVWUP7UHS | 18:06 |
| Wizzup | I don't think I had any windows open | 18:07 |
| Wizzup | also here for log purposes https://wizzup.org/x-crash-d4-xlog.txt and https://wizzup.org/x-crash-d4.txt | 18:09 |
| Wizzup | freemangordon: btw I do seem to get the notifications | 18:12 |
| Wizzup | fd 588 also sounds a bit extreme | 18:18 |
| Wizzup | this is what I have after reboot | 18:19 |
| Wizzup | # ls -lsh /proc/`pidof Xorg`/fd | grep dmabuf | wc -l | 18:19 |
| Wizzup | 179 | 18:19 |
| tmlind | freemangordon: ok around now here and there | 18:42 |
| rafael2k | Wizzup: yay! | 18:44 |
| inky | rafael2k, Wizzup, what changed? | 18:55 |
| tmlind | freemangordon: so omap_gem_pin() is hard to follow.. and that makes your patch even harder to follow :) | 19:01 |
| tmlind | freemangordon: maybe prepare things a bit first by returning early for the omap_gem_is_contiguous() related checks? | 19:02 |
| tmlind | freemangordon: or split the function into some helpers depending on the mapping type? | 19:03 |
| uvos | Wizzup: why would that be extream? x has at least one fd open per client | 19:29 |
| freemangordon | tmlind: the patch as such is ok, I mean - if Tomi requires changes I will do them. The point/question is - do you think I shall add anything to the commit message | 20:01 |
| freemangordon | like, is it clear why the patch? | 20:01 |
| freemangordon | Wizzup: hmm | 20:02 |
| freemangordon | never seen that. did you check if you have free memory? | 20:02 |
| freemangordon | maybe there is some memory leak, I will have to check allocations | 20:03 |
| tmlind | freemangordon: i doubt tomi will apply such a patch, too complicated to follow.. and he probably wants it broken into smaller chunks to review it | 20:05 |
| tmlind | just guessing of course :) | 20:06 |
| tmlind | freemangordon: i guess you can always send it to the lists and let's see what tomi says | 20:06 |
| tmlind | freemangordon: hard to say if the description is ok as i can't really follow the patch :) | 20:09 |
| rafael2k | inky: basically the support for pp is complete, all drivers are there, including modem, also the kernel has most of the modules enabled, allowing for example, all luks ciphers, packet filtering, NAT and so on | 20:10 |
| rafael2k | inky: also pp keyboard support should be there (not tested yet, keyboards are on the way) | 20:10 |
| freemangordon | tmlind: oh, ok, will try to rework it a bit to simplify it | 20:13 |
| tmlind | freemangordon: sounds good to me :) maybe separate helper functions to avoid the complicated if else stuff? | 20:14 |
| tmlind | freemangordon: i suspect your patch makes sense, it's just the current function gets interlaced into the patch badly making it hard to follow | 20:16 |
| rafael2k | inky: even some modules for android compability available in the kernel are enabled as modules, in case anyone crazy enough wants to run anbox... | 20:20 |
| freemangordon | tmlind: yeah | 20:30 |
| tmlind | uhh need to try to understand recent n_gsm.c for v5.16 branch.. need to continue tomorrow night | 21:19 |
| _inky | rafael2k: thank you! | 21:35 |
| rafael2k | : ) | 21:36 |
| Wizzup | uvos: combined with no windows open and out of memory... | 21:42 |
| Wizzup | uvos: seems fishy to me | 21:42 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!